Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for v0.8.0 release #380

Closed
wants to merge 6 commits into from
Closed

Prepare for v0.8.0 release #380

wants to merge 6 commits into from

Conversation

ssbarnea
Copy link
Member

No description provided.

@ssbarnea ssbarnea requested review from tomaciazek and a team as code owners January 14, 2022 16:03
webknjaz
webknjaz reviewed Jan 14, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Jan 14, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
webknjaz
webknjaz reviewed Jan 14, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@webknjaz
Copy link
Member

@ssbarnea is it possible to tell Jenkins to release from this branch and only then merge the PR here?

@ssbarnea
Copy link
Member Author

@ssbarnea is it possible to tell Jenkins to release from this branch and only then merge the PR here?

In theory anything is doable but I do not plan to do the extra work for that, especially as there other shaky thing involved. In fact I am considering delaying this release for next week as is already late friday.

ssbarnea and others added 3 commits January 14, 2022 16:33
@ssbarnea @webknjaz
Update CHANGELOG.md
5ef7999 
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
@ssbarnea @webknjaz
Update CHANGELOG.md
19d5ede 
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
@ssbarnea @webknjaz
Update CHANGELOG.md
37dfb88 
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
@webknjaz
Copy link
Member

delaying this release for next week as is already late friday.

Fair enough. #no_friday_releases

@ssbarnea
Copy link
Member Author

delaying this release for next week as is already late friday.

Fair enough. #no_friday_releases

I hope we can also fix #373 which is the bug that hindered @priyamsahoo e2e pull-request. We worked around it but the root cause is still very valid.

ganeshrn
ganeshrn reviewed Jan 18, 2022
View reviewed changes
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also include the recent commit in this release?

@ssbarnea
Copy link
Member Author

Can we also include the recent commit in this release?

Can you please be more explicit? I do not see anything else listed on https://github.com/ansible/vscode-ansible/releases other than the already included 3 items.

Also, I am inclined to delay this release until we fix #373 which counts as a serious bug.

@ssbarnea ssbarnea marked this pull request as draft January 18, 2022 12:02
@ssbarnea ssbarnea closed this Jan 18, 2022
@ssbarnea ssbarnea deleted the fix/schemas branch January 18, 2022 14:40
ssbarnea added a commit that referenced this pull request Mar 15, 2024
@ssbarnea @ansibuddy
More release work (#380)
b48fba1 
Co-authored-by: Ansible DevTools <[email protected]>
@ssbarnea ssbarnea mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshrn ganeshrn ganeshrn left review comments

@webknjaz webknjaz webknjaz left review comments

@tomaciazek tomaciazek Awaiting requested review from tomaciazek

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
blocked skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssbarnea @webknjaz @ganeshrn