-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansys Edb Service as stand alone package #1
Conversation
Changes associated to the extraction - the build system leverages ansys_tools_protoc_helper. - ignore autogenerated python code (*pb2*.py and *pb2*.pyi) - update licence year - rename package info to use v0 instead of v1
Changes associated to the extraction - package renamged ansys.api.edb.v0 - import have been rewritten to match import "ansys/api/edb/v0/*.proto"
1ecc86a
to
dd08706
Compare
Note Current protolint step does not leverage the github action plexsystems/[email protected]. Once the package is released in public, we should switch to it.
dd08706
to
55b1f7d
Compare
as discussed offline, let's use
looks good with
|
@hiro727 Thanks for the feedback, I'll split this PR into two parts (one to be accepted, the other as pending). |
@SMoraisAnsys Just to double check, did you mean to reference the pull request fix circular imports #313 or the issue Circular import error when importing terminal #312? I wanted to make sure I'm putting my comments in the right place. Thanks! |
When hiroki was speaking about sbolute imports I though he was refering to the circular import issue. However that was a mistake. He was speaking about having absolute imports on client side while having something different on server side. Sorry for the confusion :s |
Extract the code related to gRPC Ansys Edb Service from pyedb.
The resulting project should be a stand alone package used as a dependency of pyedb.
Changes from original repo: