Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open sourcing pending changes #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SMoraisAnsys
Copy link
Contributor

Pending extraction includes the following changes:

  • add CI build job with protolint step (TODO: use plexsystems/[email protected] once public)
  • update sources following protolint report:
    • material_def.proto: rename materialDef -> material_def; propertyId -> property_id
    • package_def.proto: rename
      • GetTherm_Cond -> GetThermCond
      • SetTherm_Cond -> SetThermCond
      • GetTheta_JB -> GetThetaJB
      • SetTheta_JB -> SetThetaJB
      • GetTheta_JC -> GetThetaJC
      • SetTheta_JC -> SetThetaJC

Note: the branched used for this PR follows #2.

Changes associated to the extraction
- the build system leverages ansys_tools_protoc_helper.
- ignore autogenerated python code (*pb2*.py and *pb2*.pyi)
- update licence year
Changes associated to the extraction:
- import have been rewritten to match import "ansys/api/edb/v1/*.proto"
Note
Current protolint step does not leverage the github action
plexsystems/[email protected]. Once the package is released
in public, we should switch to it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants