-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/reuse 2.0 implementation #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
maintenance
Package and maintenance related
bug
Something isn't working
labels
Jul 28, 2023
RobPasMue
requested changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's talk about some of the changes here. Overall they look good, but the docstrings are totally off. Please align to numpydoc style.
Co-authored-by: Roberto Pastor Muela <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
…ys/pre-commit-hooks into fix/reuse-2.0-implementation
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Jul 31, 2023
RobPasMue
reviewed
Aug 1, 2023
Co-authored-by: Roberto Pastor Muela <[email protected]>
klmcadams
commented
Aug 1, 2023
RobPasMue
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
maintenance
Package and maintenance related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed add_license_header.py reuse implementation to run on reuse>=2, and adjusted unit tests to correspond with new add_license_header code.
Return codes:
0 - add_license_header passes (no files changed)
1 - add_license_header changed one or more files using reuse
2 - add_license_header cannot find .reuse directory in root of git repository, so reuse is not run on existing noncompliant files.
Closes #10 and #12.