Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rlc with gap port bug fix #3862

Merged
merged 27 commits into from
Nov 10, 2023
Merged

Conversation

svandenb-dev
Copy link
Collaborator

bub fixed

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@svandenb-dev svandenb-dev linked an issue Nov 10, 2023 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the edb label Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #3862 (226f1b0) into main (c318320) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

❗ Current head 226f1b0 differs from pull request most recent head 57136a9. Consider uploading reports for the commit 57136a9 to get more accurate results

@@            Coverage Diff             @@
##             main    #3862      +/-   ##
==========================================
- Coverage   81.25%   81.24%   -0.02%     
==========================================
  Files         182      182              
  Lines       62678    62680       +2     
==========================================
- Hits        50930    50924       -6     
- Misses      11748    11756       +8     

@svandenb-dev svandenb-dev enabled auto-merge (squash) November 10, 2023 11:01
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 7b692a2 into main Nov 10, 2023
11 checks passed
@svandenb-dev svandenb-dev deleted the replace_rlc_with_gap_port_bug_fix branch November 10, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EDB API: deactivate_rlc_component doesn't make a proper gap port.
3 participants