-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Farfield refactoring #4893
Conversation
# Conflicts: # pyaedt/generic/plot.py
# Conflicts: # doc/source/API/Post.rst
# Conflicts: # doc/source/API/Visualization.rst
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4893 +/- ##
==========================================
+ Coverage 82.26% 83.65% +1.38%
==========================================
Files 120 121 +1
Lines 54561 54799 +238
==========================================
+ Hits 44886 45843 +957
+ Misses 9675 8956 -719 |
@SMoraisAnsys Any idea why documentation style is failing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this huge rework and great use of "scope" with variable/method names !
Warning: while this is a great change, you have to really rack your brain to ensure that the scope you defined won't change later on as this will be though to handle !
I left some minor comments. Among them is the fact of returning directly a value instead of using else
statement before. JFYI, if we don't specify a value to be returned, Python returns None
by default. So, we can discard return None
if you want !
No description provided.