Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Farfield refactoring #4893

Merged
merged 46 commits into from
Jul 31, 2024
Merged

FEAT: Farfield refactoring #4893

merged 46 commits into from
Jul 31, 2024

Conversation

Samuelopez-ansys
Copy link
Member

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the examples Anything related to the examples label Jul 8, 2024
@Samuelopez-ansys Samuelopez-ansys changed the title Farfield refactoring FEAT: Farfield refactoring Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 90.60078% with 97 lines in your changes missing coverage. Please review.

Project coverage is 83.65%. Comparing base (b0f022b) to head (bd57746).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4893      +/-   ##
==========================================
+ Coverage   82.26%   83.65%   +1.38%     
==========================================
  Files         120      121       +1     
  Lines       54561    54799     +238     
==========================================
+ Hits        44886    45843     +957     
+ Misses       9675     8956     -719     

@Samuelopez-ansys
Copy link
Member Author

@SMoraisAnsys Any idea why documentation style is failing?

@Samuelopez-ansys Samuelopez-ansys marked this pull request as ready for review July 29, 2024 08:05
@Samuelopez-ansys Samuelopez-ansys added the enhancement New features or code improvements label Jul 29, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this huge rework and great use of "scope" with variable/method names !
Warning: while this is a great change, you have to really rack your brain to ensure that the scope you defined won't change later on as this will be though to handle !

I left some minor comments. Among them is the fact of returning directly a value instead of using else statement before. JFYI, if we don't specify a value to be returned, Python returns None by default. So, we can discard return None if you want !

doc/source/API/Visualization.rst Outdated Show resolved Hide resolved
pyaedt/generic/farfield_visualization.py Show resolved Hide resolved
pyaedt/generic/farfield_visualization.py Outdated Show resolved Hide resolved
pyaedt/generic/farfield_visualization.py Outdated Show resolved Hide resolved
pyaedt/generic/farfield_visualization.py Outdated Show resolved Hide resolved
pyaedt/generic/farfield_visualization.py Outdated Show resolved Hide resolved
pyaedt/generic/farfield_visualization.py Outdated Show resolved Hide resolved
pyaedt/generic/farfield_visualization.py Outdated Show resolved Hide resolved
pyaedt/generic/farfield_visualization.py Outdated Show resolved Hide resolved
pyaedt/generic/farfield_visualization.py Outdated Show resolved Hide resolved
@SMoraisAnsys SMoraisAnsys merged commit fb44e5a into main Jul 31, 2024
44 of 45 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the farfield_refactoring branch August 9, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements examples Anything related to the examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants