FIX: Pyvista not included in doc-no-examples dependencies #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
maintenance
maxcapodi78
previously approved these changes
Jul 31, 2024
|
Why would we need the |
SMoraisAnsys
approved these changes
Jul 31, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4977 +/- ##
==========================================
- Coverage 83.65% 83.53% -0.12%
==========================================
Files 121 121
Lines 54791 54793 +2
==========================================
- Hits 45838 45774 -64
- Misses 8953 9019 +66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging #4893 the step
doc-buildwas not performed because it requiresdoc-stylewhich couldn't run because too many changes were performed.This led to a main branch with documentation extended and missing
pyistadependency.