FIX: Added separation of faces and objects in assign_voltage method #5008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
AlfVII
changed the title
|
@ansys-reviewer-bot review |
|
Okay, I will trigger a review of your PR. |
![ansys-reviewer-bot[bot]](https://avatars.githubusercontent.com/in/383621?s=60&v=4){kind=small}
Co-authored-by: ansys-reviewer-bot[bot] <143693109+ansys-reviewer-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was implementing Electrostatic solver for Ansyas, and I got an error when assigning voltages to a list of more than one objects. I looked the code a bit and I saw (in maxwell.py, lines 980-986) that you distinguish between list of one element and more than one.
When there is only one you check if the elements are objects or faces and assign in correspondence. When there are more than one you always assign them as "Faces", which breaks the code when working with objects.