Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Separation of faces and objects in assign voltage method #5010

Conversation

Samuelopez-ansys
Copy link
Member

Cherry pick: #5008

AlfVII and others added 3 commits August 7, 2024 13:18
Co-authored-by: ansys-reviewer-bot[bot] <143693109+ansys-reviewer-bot[bot]@users.noreply.github.com>
(cherry picked from commit 917423d)
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.38%. Comparing base (d51bd8b) to head (7b5a974).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5010      +/-   ##
==========================================
+ Coverage   79.20%   83.38%   +4.18%     
==========================================
  Files         122      122              
  Lines       54938    54943       +5     
==========================================
+ Hits        43511    45814    +2303     
+ Misses      11427     9129    -2298     

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) August 8, 2024 14:48
@Samuelopez-ansys Samuelopez-ansys merged commit 3066a07 into main Aug 8, 2024
44 of 45 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/separation-of-faces-and-objects-in-assign_voltage-method branch August 8, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants