Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: spice model terminal pair #769

Merged
merged 6 commits into from
Sep 4, 2024
Merged

FEAT: spice model terminal pair #769

merged 6 commits into from
Sep 4, 2024

Conversation

hui-zhou-a
Copy link
Collaborator

No description provided.

@hui-zhou-a hui-zhou-a linked an issue Sep 4, 2024 that may be closed by this pull request
SMoraisAnsys
SMoraisAnsys previously approved these changes Sep 4, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left minor comments

src/pyedb/dotnet/edb_core/cell/hierarchy/component.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/cell/hierarchy/component.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 1f064fe into main Sep 4, 2024
25 checks passed
@svandenb-dev svandenb-dev deleted the feat-spice-model branch September 4, 2024 11:49
@aohta2021
Copy link

I have confirmed SPICE model can assigned by Json config file.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add terminal pairs support in spice assignment
4 participants