Standardizing Windows data path and removing folder creation on import #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raph-luc
changed the title
raph-luc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same user data path naming scheme as in ansys/pyfluent#1615, ansys/pymapdl#2064, ansys/pyprimemesh#485, ansys/ansys-tools-path#44, ansys/pysystem-coupling#158, ansys/pymechanical#257
Original issue tracker ansys/pyfluent#1588
Changes Windows data path from
%LocalAppData%\ansys_mapdl_reader\ansys_mapdl_readerto%LocalAppData%\Ansys\ansys_mapdl_reader, no change to the path on LinuxRemoved what looks like an unnecessary try-except block
Also changed it so that the examples and data path folders are not created immediately on import regardless of whether they will be used. They are instead created when downloading example files through
downloads._retrieve_file(), as that seems to be the only place where these directories were used in this module