Standardizing Windows data path #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
iboyd-ansys
approved these changes
May 31, 2023
There was a problem hiding this comment.
Thanks @raph-luc - looks good.
Sorry about the delay - I am on leave this week so had not been looking in.
|
Thanks @iboyd-ansys, and no problem at all. Merging this as it passed all the tests. Please let me know if any issues come up due to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change when running on Windows: from
USER_DATA_PATHresolving to%LocalAppData%\ansys_systemcoupling_core\ansys_systemcoupling_core, changed to%LocalAppData%\Ansys\ansys_systemcoupling_coreusing the same root folder%LocalAppData%\Ansysas other applications. No change on Linux, resolves to~/.local/share/ansys_systemcoupling_core.Original issue tracker ansys/pyfluent#1588
Same Windows data path naming scheme as in ansys/pyfluent#1615, ansys/pymapdl#2064, ansys/pyprimemesh#485, ansys/ansys-tools-path#44
Also removed try-except block
Food for thought: data path and examples folders are immediately created when
import ansys.systemcoupling.core, might be worth changing to create folders only when/if they are actually used