Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FP Refactor #28

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

FP Refactor #28

wants to merge 44 commits into from
+1,085 −857

Commits on Feb 23, 2017

  1. ResultT transformer and syntax

    @raulraja
    raulraja committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    7c6cb08 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2017

  1. Refactored getAlbum by Id call until Interactor. Next: remove event bus

    @raulraja
    raulraja committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    dfb9e58 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2017

  1. Refactored getAlbum by Id call

    @raulraja
    raulraja committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    8a992f4 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2017

  1. Work In Progress: Migration of artist logic to the new FP approach

    @jrgonzalezg
    jrgonzalezg committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    24b7b57 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from jrgonzalezg/rr-fp-refactor 

    Work In Progress: Migration of artist logic to the new FP approach
    @raulraja
    raulraja authored Mar 2, 2017
    Configuration menu
    Copy the full SHA
    d2b6dec View commit details
    Browse the repository at this point in the history

  3. Improved Gradle build configuration and updated many dependencies

    @jrgonzalezg
    jrgonzalezg committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    40aaadb View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2 from jrgonzalezg/rr-fp-refactor 

    Improved Gradle build configuration and updated many dependencies
    @raulraja
    raulraja authored Mar 2, 2017
    Configuration menu
    Copy the full SHA
    a0a1187 View commit details
    Browse the repository at this point in the history

  5. Initial attempt to refactor datasets (now datasources) and repository… 

    … code. Partial corrections to tests (still do not work / compile)
    @jrgonzalezg
    jrgonzalezg committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    0655767 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #3 from jrgonzalezg/rr-fp-refactor 

    Initial attempt to refactor datasets (now datasources) and repository…
    @raulraja
    raulraja authored Mar 2, 2017
    Configuration menu
    Copy the full SHA
    3960350 View commit details
    Browse the repository at this point in the history

  7. Introduces ResultT.firstResultOf to generalize iteration looking fo… 

    …r success over chained promises
    @raulraja
    raulraja committed Mar 2, 2017
    6 Configuration menu
    Copy the full SHA
    20e8f28 View commit details
    Browse the repository at this point in the history

  8. Added NonEmptyList for more constrained result types

    @raulraja
    raulraja committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    a24b233 View commit details
    Browse the repository at this point in the history

  9. Refactored call to getRecommendedArtists

    @raulraja
    raulraja committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    1c7e969 View commit details
    Browse the repository at this point in the history

  10. Added missing call to runOnUiThread

    @raulraja
    raulraja committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    9302967 View commit details
    Browse the repository at this point in the history

  11. Improved inference for extension methods left & right

    @raulraja
    raulraja committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    2ab7586 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2017

  1. Avoid invoking f twice on firstSuccessIn

    @raulraja
    raulraja committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    05ea9cd View commit details
    Browse the repository at this point in the history

  2. Reoganized Result to become a more proper datatype

    @raulraja
    raulraja committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    f25c80b View commit details
    Browse the repository at this point in the history

  3. Partial conversion of the top albums logic to the functional style (t… 

    …he biggest missing part is a proper implementation of CloudAlbumDataSource::requestTopAlbums()). Removed unused classes and libraries for buses, interactors and jobs. Some additional minor changes and simplifications.
    @jrgonzalezg
    jrgonzalezg committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    22f1fab View commit details
    Browse the repository at this point in the history

  4. Merge pull request #4 from jrgonzalezg/rr-fp-refactor 

    Partial conversion of the top albums logic to the functional style (the biggest...
    @raulraja
    raulraja authored Mar 3, 2017
    Configuration menu
    Copy the full SHA
    0e038ed View commit details
    Browse the repository at this point in the history

  5. traverse, sequence, fold and reduce for the Result data type

    @raulraja
    raulraja committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    214619b View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2017

  1. Some performance improvements to NonEmptyList. Refactored the whole p… 

    …roject code using the default Android Studio 2.3 code style to make the project more coherent in terms of formatting.
    @jrgonzalezg
    jrgonzalezg committed Mar 4, 2017
    Configuration menu
    Copy the full SHA
    e59baca View commit details
    Browse the repository at this point in the history

  2. Further performance improvements to NonEmptyList

    @jrgonzalezg
    jrgonzalezg committed Mar 4, 2017
    Configuration menu
    Copy the full SHA
    ef7f49e View commit details
    Browse the repository at this point in the history

  3. Enabled kotlin coroutines

    @jrgonzalezg
    jrgonzalezg committed Mar 4, 2017
    Configuration menu
    Copy the full SHA
    8340f68 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #5 from jrgonzalezg/rr-fp-refactor 

    Some performance improvements to NonEmptyList. Refactored the whole p…
    @raulraja
    raulraja authored Mar 4, 2017
    Configuration menu
    Copy the full SHA
    93f5f77 View commit details
    Browse the repository at this point in the history

  5. for comprehensions draft implemented with coroutines

    @raulraja
    raulraja committed Mar 4, 2017
    Configuration menu
    Copy the full SHA
    ef77f1c View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2017

  1. Add toString, equals and hashCode to NonEmptyList

    pakoito committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    012f55e View commit details
    Browse the repository at this point in the history

  2. Fixed inheritance issues on NonEmptyList. Reformatted predef.kt file.

    @jrgonzalezg
    jrgonzalezg committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    af9b3ca View commit details
    Browse the repository at this point in the history

  3. Refactor move predef to a new module with package com.finecinnamon

    pakoito committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    353eb54 View commit details
    Browse the repository at this point in the history

  4. Fix broken coroutine. Rename binding {} as bind {}.

    pakoito committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    a48868f View commit details
    Browse the repository at this point in the history

  5. Add tests

    pakoito committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    d254017 View commit details
    Browse the repository at this point in the history

  6. Refactor update CloudAlbumDataSource to new bind

    pakoito committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    1e622ad View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/rr-fp-refactor' into rr-fp-refactor 

    # Conflicts:
#	tools/src/main/java/com/finecinnamon/predef.kt
    pakoito committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    0e27362 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/rr-fp-refactor' into rr-fp-refactor 

    # Conflicts:
#	tools/src/main/java/com/finecinnamon/predef.kt
    pakoito committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    9ccc98f View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into rr-fp-refactor

    @jrgonzalezg
    jrgonzalezg committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    18ebb54 View commit details
    Browse the repository at this point in the history

  10. binding syntax for monadic comprehensions over results

    @raulraja
    raulraja committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    e008201 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2017

  1. Updated and homogenized dependencies and Gradle

    @jrgonzalezg
    jrgonzalezg committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    1491b7e View commit details
    Browse the repository at this point in the history

  2. Updated Android Support dependencies

    @jrgonzalezg
    jrgonzalezg committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    46af953 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2017

  1. Merge branch 'master' into rr-fp-refactor

    @jrgonzalezg
    jrgonzalezg committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    415b0b2 View commit details
    Browse the repository at this point in the history

  2. Replaced kotlin-stdlib dependency with kotlin-stdlib-jre7 as suggeste… 

    …d by the IDE
    @jrgonzalezg
    jrgonzalezg committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    8da516f View commit details
    Browse the repository at this point in the history

  3. Enabled kotlinx coroutines including new android module. Moved corout… 

    …ine enabling from build.gradle files to gradle.properties
    @jrgonzalezg
    jrgonzalezg committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    24d5d68 View commit details
    Browse the repository at this point in the history

  4. Added immutable collections dependency from the kotlinx-collections-i… 

    …mmutable proposal that are based on PCollections
    @jrgonzalezg
    jrgonzalezg committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    77b4467 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2017

  1. Renamed tools module and its packages. Reapplied default IDEA code st… 

    …yle and import optimizer to the whole project.
    @jrgonzalezg
    jrgonzalezg committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    dccb8b9 View commit details
    Browse the repository at this point in the history

  2. Initial work towards controlling the lifecycle and the app tasks with… 

    … coroutines
    @jrgonzalezg
    jrgonzalezg committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    b29ffb6 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2017

  1. Updated dependencies

    @jrgonzalezg
    jrgonzalezg committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    16ef99c View commit details
    Browse the repository at this point in the history

Commits on May 20, 2017

  1. Merge branch 'master' into rr-fp-refactor

    @jrgonzalezg
    jrgonzalezg committed May 20, 2017
    Configuration menu
    Copy the full SHA
    3dc5a5d View commit details
    Browse the repository at this point in the history