Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish antctl binaries for different platforms in releases #312

Closed
weiqiangt opened this issue Jan 14, 2020 · 3 comments · Fixed by #517
Closed

Publish antctl binaries for different platforms in releases #312

weiqiangt opened this issue Jan 14, 2020 · 3 comments · Fixed by #517
Assignees
Labels
area/build-release Issues or PRs related to building and releasing area/component/antctl Issues or PRs releated to the command line interface component enhancement New feature or request kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@weiqiangt
Copy link
Contributor

Describe the problem/challenge you have
The antctl binaries are not included in release publish.

Describe the solution you'd like
Publish antctl binaries for different platforms in releases.
Also publish the antctl deploy yaml and image when #310 is implemented.

Anything else you would like to add?
Need to consider the name of antctl for each platform

@weiqiangt weiqiangt added the enhancement New feature or request label Jan 14, 2020
@weiqiangt
Copy link
Contributor Author

weiqiangt commented Jan 16, 2020

Hi @antoninbas, it looks like binaries in the release page are uploaded manually? If so, I think there is no change that should be involved in the repo?
I see Kind publishes binaries for different platforms in the form kind-{platform}, could we also follow this style?

@antoninbas antoninbas added this to the Antrea v0.3.0 release milestone Jan 21, 2020
@antoninbas
Copy link
Contributor

@weiqiangt @lzhecheng

yes I will take care of publishing the antctl binaries for linux / macOS / windows for upcoming releases

we do not publish any binary at the moment, just the antrea manifest, but that will change starting with 0.3.0

it will be manual at first (I'll add a script to the repo, a bit like what Kind does), but we can look into automating it later (maybe using something like goreleaser as a starting point?)

@antoninbas
Copy link
Contributor

We discussed this at the 01/22/2020 Antrea community meeting. We decided to postpone publishing the binaries until the next release for 2 reasons:

  • no available user-facing documentation yet (see Document antctl #337)
  • the only "useful" command that may be part of the release (agent-info - Implement antctl agent-info #318) can only be run locally from within the agent Pod. Since the Antrea docker container already includes the antctl binary, there is really no need to distribute a binary with the release as well. When antctl provides some useful commands that can be run from out-of-cluster, we can reconsider

@McCodeman McCodeman added area/component/antctl Issues or PRs releated to the command line interface component kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/build-release Issues or PRs related to building and releasing labels Feb 12, 2020
@antoninbas antoninbas self-assigned this Mar 11, 2020
antoninbas added a commit to antoninbas/antrea that referenced this issue Mar 19, 2020
When creating a release, the necessary assets (yaml manifests and antctl
binaries) will now be added to the release automatically by a Github
workflow. This reduces the potential for human error.

For antctl, we build and upload the following binaries:
 * linux: amd64, arm64, arm (arm/v7)
 * darwin: amd64
 * windows: amd64

Fixes antrea-io#312
antoninbas added a commit to antoninbas/antrea that referenced this issue Mar 19, 2020
When creating a release, the necessary assets (yaml manifests and antctl
binaries) will now be added to the release automatically by a Github
workflow. This reduces the potential for human error.

For antctl, we build and upload the following binaries:
 * linux: amd64, arm64, arm (arm/v7)
 * darwin: amd64
 * windows: amd64

Fixes antrea-io#312
antoninbas added a commit to antoninbas/antrea that referenced this issue Mar 23, 2020
When creating a release, the necessary assets (yaml manifests and antctl
binaries) will now be added to the release automatically by a Github
workflow. This reduces the potential for human error.

For antctl, we build and upload the following binaries:
 * linux: amd64, arm64, arm (arm/v7)
 * darwin: amd64
 * windows: amd64

Fixes antrea-io#312
antoninbas added a commit to antoninbas/antrea that referenced this issue Mar 25, 2020
When creating a release, the necessary assets (yaml manifests and antctl
binaries) will now be added to the release automatically by a Github
workflow. This reduces the potential for human error.

For antctl, we build and upload the following binaries:
 * linux: amd64, arm64, arm (arm/v7)
 * darwin: amd64
 * windows: amd64

Fixes antrea-io#312
antoninbas added a commit that referenced this issue Mar 25, 2020
When creating a release, the necessary assets (yaml manifests and antctl
binaries) will now be added to the release automatically by a Github
workflow. This reduces the potential for human error.

For antctl, we build and upload the following binaries:
 * linux: amd64, arm64, arm (arm/v7)
 * darwin: amd64
 * windows: amd64

Fixes #312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-release Issues or PRs related to building and releasing area/component/antctl Issues or PRs releated to the command line interface component enhancement New feature or request kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants