Automate asset upload when creating a release #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
|
For an example, see https://github.com/antoninbas/antrea/releases/tag/v0.5.0-antonin-rc.2 |
antoninbas
force-pushed
the
upload-assets-for-release
branch
from
d84a65e
to
e1d6678
Compare
antoninbas
force-pushed
the
upload-assets-for-release
branch
from
e1d6678
to
3cf9866
Compare
|
Thanks @jianjuns. I will merge this shortly before the release, in case we include GKE support in 0.5. |
weiqiangt
previously approved these changes
Mar 24, 2020
abhiraut
previously approved these changes
Mar 25, 2020
When creating a release, the necessary assets (yaml manifests and antctl binaries) will now be added to the release automatically by a Github workflow. This reduces the potential for human error. For antctl, we build and upload the following binaries: * linux: amd64, arm64, arm (arm/v7) * darwin: amd64 * windows: amd64 Fixes antrea-io#312
antoninbas
dismissed stale reviews from abhiraut, weiqiangt, and jianjuns
via
1861141
antoninbas
force-pushed
the
upload-assets-for-release
branch
from
3cf9866
to
1861141
Compare
|
/skip-all |
|
Updated the PR with the following:
|
jianjuns
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a release, the necessary assets (yaml manifests and antctl
binaries) will now be added to the release automatically by a Github
workflow. This reduces the potential for human error.
For antctl, we build and upload the following binaries:
Fixes #312