Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy Antrea APIs (*.antrea.tanzu.vmware.com) in v1.6 #3298

Closed
antoninbas opened this issue Feb 9, 2022 · 0 comments · Fixed by #3299
Closed

Remove legacy Antrea APIs (*.antrea.tanzu.vmware.com) in v1.6 #3298

antoninbas opened this issue Feb 9, 2022 · 0 comments · Fixed by #3299
Assignees
@antoninbas
Labels
api-review Categorizes an issue or PR as actively needing an API review. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API. kind/design Categorizes issue or PR as related to design.
Milestone
Antrea v1.6 release

Comments

@antoninbas
Copy link
Contributor

Describe what you are trying to solve
These legacy APIs (and the mirroring controller that goes with them) were scheduled for deletion in December 2021 as per our documentation. By the time Antrea v1.6 is released, we will have supported the legacy APIs post-deprecation for about 1 year.

Describe the solution you have in mind
Remove everything related from these APIs from the Antrea manifests. Remove all the code from the Agent & Controller which deals with these APIs. Explicitly delete the removed APIServices during Controller initialization to avoid failures during upgrades.

Describe how your solution impacts user flows

  • users who are still on Antrea < v1.0 and want to upgrade to Antrea >= v1.6 will need an intermediate upgrade so they can migrate with as little disruption as possible
  • after a successful upgrade to Antrea >= v1.6, users may want to explicitly delete legacy resources (webhooks, CRDs); APIServices are deleted by Antrea

Both of these should be documented before the release.

Test plan
Run the regular test suites. Emphasis should be put on upgrade testing. In addition to the automated upgrade tests, we may want to test a v1.5 -> v1.6 (pre-release) upgrade manually for added safety.
@antoninbas antoninbas added api-review Categorizes an issue or PR as actively needing an API review. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API. kind/design Categorizes issue or PR as related to design. labels Feb 9, 2022
@antoninbas antoninbas added this to the Antrea v1.6 release milestone Feb 9, 2022
@antoninbas antoninbas self-assigned this Feb 9, 2022
antoninbas added a commit to antoninbas/antrea that referenced this issue Feb 9, 2022
@antoninbas
Remove all legacy (*.antrea.tanzu.vmware.com) APIs
fc585fe 
These APIs were scheduled for deletion in December 2021. So it seems
reasonable to remove them in Antrea v1.6, without causing significant
disruption to users.

As part of this, the CRD mirroring controller code can be removed
entirely and the legacyCRDMirroring config option for the controller is
deprecated (it's a no-op and users trying to set this option to anything
will see a warning in the logs).

The API dcoumentation is updated. We add a note to inform users who may
still be using Antrea pre-v1.0 that they will need to make an
intermediate upgrade first and migrate their CRDs, if they want to
upgrade to Antrea >= v1.6.

Fixes antrea-io#3298

Signed-off-by: Antonin Bas <[email protected]>
@antoninbas antoninbas mentioned this issue Feb 9, 2022
Merged
antoninbas added a commit to antoninbas/antrea that referenced this issue Feb 10, 2022
@antoninbas
Remove all legacy (*.antrea.tanzu.vmware.com) APIs
1a47643 
These APIs were scheduled for deletion in December 2021. So it seems
reasonable to remove them in Antrea v1.6, without causing significant
disruption to users.

As part of this, the CRD mirroring controller code can be removed
entirely and the legacyCRDMirroring config option for the controller is
deprecated (it's a no-op and users trying to set this option to anything
will see a warning in the logs).

The API dcoumentation is updated. We add a note to inform users who may
still be using Antrea pre-v1.0 that they will need to make an
intermediate upgrade first and migrate their CRDs, if they want to
upgrade to Antrea >= v1.6.

Fixes antrea-io#3298

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit that referenced this issue Feb 15, 2022
@antoninbas
Remove all legacy (*.antrea.tanzu.vmware.com) APIs (#3299)
c3621fb 
These APIs were scheduled for deletion in December 2021. So it seems
reasonable to remove them in Antrea v1.6, without causing significant
disruption to users.

As part of this, the CRD mirroring controller code can be removed
entirely and the legacyCRDMirroring config option for the controller is
deprecated (it's a no-op and users trying to set this option to anything
will see a warning in the logs).

The API documentation is updated. We add a note to inform users who may
still be using Antrea pre-v1.0 that they will need to make an
intermediate upgrade first and migrate their CRDs, if they want to
upgrade to Antrea >= v1.6.

Fixes #3298

Signed-off-by: Antonin Bas <[email protected]>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this issue Mar 2, 2022
@antoninbas
Remove all legacy (*.antrea.tanzu.vmware.com) APIs (antrea-io#3299)
8c51d4f 
These APIs were scheduled for deletion in December 2021. So it seems
reasonable to remove them in Antrea v1.6, without causing significant
disruption to users.

As part of this, the CRD mirroring controller code can be removed
entirely and the legacyCRDMirroring config option for the controller is
deprecated (it's a no-op and users trying to set this option to anything
will see a warning in the logs).

The API documentation is updated. We add a note to inform users who may
still be using Antrea pre-v1.0 that they will need to make an
intermediate upgrade first and migrate their CRDs, if they want to
upgrade to Antrea >= v1.6.

Fixes antrea-io#3298

Signed-off-by: Antonin Bas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoninbas antoninbas

Labels
api-review Categorizes an issue or PR as actively needing an API review. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API. kind/design Categorizes issue or PR as related to design.
Projects
None yet
Milestone
Antrea v1.6 release
Development

Successfully merging a pull request may close this issue.

Remove all legacy (*.antrea.tanzu.vmware.com) APIs antoninbas/antrea
1 participant
@antoninbas