Remove all legacy (*.antrea.tanzu.vmware.com) APIs #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
requested review from
hongliangl,
Dyanngg,
jianjuns,
salv-orlando and
tnqn
antoninbas
added
api-review
Codecov Report
@@ Coverage Diff @@
## main #3299 +/- ##
==========================================
- Coverage 58.97% 54.79% -4.19%
==========================================
Files 331 371 +40
Lines 28420 50756 +22336
==========================================
+ Hits 16762 27810 +11048
- Misses 9843 20543 +10700
- Partials 1815 2403 +588
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jianjuns
reviewed
Feb 10, 2022
hongliangl
reviewed
Feb 10, 2022
tnqn
added
the
action/release-note
tnqn
reviewed
Feb 10, 2022
|
/test-all |
Hopefully not. This was required because of the API naming change. CRD version changes don't require our own mirroring logic as K8s provides the machinery for version conversion. |
These APIs were scheduled for deletion in December 2021. So it seems reasonable to remove them in Antrea v1.6, without causing significant disruption to users. As part of this, the CRD mirroring controller code can be removed entirely and the legacyCRDMirroring config option for the controller is deprecated (it's a no-op and users trying to set this option to anything will see a warning in the logs). The API dcoumentation is updated. We add a note to inform users who may still be using Antrea pre-v1.0 that they will need to make an intermediate upgrade first and migrate their CRDs, if they want to upgrade to Antrea >= v1.6. Fixes antrea-io#3298 Signed-off-by: Antonin Bas <[email protected]>
Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
remove-legacy-apis
branch
from
fc585fe
to
3aea040
Compare
|
/test-all |
|
/test-e2e |
bangqipropel
pushed a commit
to bangqipropel/antrea
that referenced
this pull request
Mar 2, 2022
These APIs were scheduled for deletion in December 2021. So it seems reasonable to remove them in Antrea v1.6, without causing significant disruption to users. As part of this, the CRD mirroring controller code can be removed entirely and the legacyCRDMirroring config option for the controller is deprecated (it's a no-op and users trying to set this option to anything will see a warning in the logs). The API documentation is updated. We add a note to inform users who may still be using Antrea pre-v1.0 that they will need to make an intermediate upgrade first and migrate their CRDs, if they want to upgrade to Antrea >= v1.6. Fixes antrea-io#3298 Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These APIs were scheduled for deletion in December 2021. So it seems
reasonable to remove them in Antrea v1.6, without causing significant
disruption to users.
As part of this, the CRD mirroring controller code can be removed
entirely and the legacyCRDMirroring config option for the controller is
deprecated (it's a no-op and users trying to set this option to anything
will see a warning in the logs).
The API dcoumentation is updated. We add a note to inform users who may
still be using Antrea pre-v1.0 that they will need to make an
intermediate upgrade first and migrate their CRDs, if they want to
upgrade to Antrea >= v1.6.
Fixes #3298
Signed-off-by: Antonin Bas [email protected]