Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parameterize kubernetes download path #2174

Merged
merged 1 commit into from
May 19, 2021
Merged

parameterize kubernetes download path #2174

merged 1 commit into from
May 19, 2021

Conversation

jayunit100
Copy link
Contributor

@lzhecheng
Copy link
Contributor

@jayunit100 do you think we can update links in hack/windows/Prepare-Node.ps1 as well?

@tnqn
Copy link
Member

tnqn commented May 19, 2021

@lzhecheng if the PR itself works, how about we merge it as is and you could follow up with another PR to update Prepare-Node.ps1?

@lzhecheng lzhecheng self-requested a review May 19, 2021 12:57
lzhecheng
lzhecheng approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@lzhecheng lzhecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzhecheng
Copy link
Contributor

@tnqn sure, let's merge this one first.
/skip-all

@lzhecheng lzhecheng merged commit 971d66c into antrea-io:main May 19, 2021
@lzhecheng lzhecheng mentioned this pull request May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzhecheng lzhecheng lzhecheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayunit100 @lzhecheng @tnqn