Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize kubernetes download path (Prepare-Node.ps1) #2192

Merged
merged 1 commit into from
May 20, 2021

Conversation

lzhecheng
Copy link
Contributor

Signed-off-by: Zhecheng Li [email protected]

Follow up of #2174

@lzhecheng lzhecheng requested a review from tnqn May 19, 2021 13:05
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

Merging #2192 (4db28e7) into main (971d66c) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2192      +/-   ##
==========================================
+ Coverage   61.09%   61.11%   +0.01%     
==========================================
  Files         273      273              
  Lines       20646    20646              
==========================================
+ Hits        12613    12617       +4     
+ Misses       6715     6710       -5     
- Partials     1318     1319       +1     
Flag Coverage Δ
kind-e2e-tests 52.06% <ø> (+0.02%) ⬆️
unit-tests 41.04% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/networkpolicy/status_controller.go 85.16% <0.00%> (-1.94%) ⬇️
pkg/agent/openflow/pipeline.go 71.14% <0.00%> (+0.17%) ⬆️
pkg/agent/route/route_linux.go 43.63% <0.00%> (+0.54%) ⬆️
pkg/agent/agent.go 47.74% <0.00%> (+0.71%) ⬆️

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzhecheng
Copy link
Contributor Author

/skip-all

@lzhecheng lzhecheng merged commit 8a0c65c into antrea-io:main May 20, 2021
@lzhecheng lzhecheng deleted the k8s-dl-path branch May 20, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants