Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18: Make the quic server connection table use an async lock, reducing thrashing (backport of #293) #300

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 18, 2024

Problem

Usage of sync locks on the quic server can cause thrashing when under lock contention

Summary of Changes

Use async lock

Fixes #


This is an automatic backport of pull request #293 done by [Mergify](https://mergify.com).

…ashing (#293)

Make the quic server connection table use an async lock, reducing lock contention

(cherry picked from commit 36e9765)
Copy link

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

@lijunwangs lijunwangs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lijunwangs lijunwangs merged commit b01b0d0 into v1.18 Mar 22, 2024
33 checks passed
@lijunwangs lijunwangs deleted the mergify/bp/v1.18/pr-293 branch March 22, 2024 23:32
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
…ing thrashing (backport of anza-xyz#293) (anza-xyz#300)

Make the quic server connection table use an async lock, reducing thrashing (anza-xyz#293)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants