This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix: only remove tooltips relating to a single vis #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
force-pushed
the
erik-ritter--fix-tooltip-removal
branch
from
5f8ffc7
to
6608b58
Compare
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 25.9% 25.14% -0.76%
==========================================
Files 8 8
Lines 166 171 +5
Branches 10 10
==========================================
Hits 43 43
- Misses 122 127 +5
Partials 1 1
Continue to review full report at Codecov.
|
kristw
approved these changes
Aug 6, 2019
|
|
||
| function componentWillUnmount() { | ||
| hideTooltips(true); | ||
| const { id } = this.props; // eslint-disable-line babel/no-invalid-this | ||
| if (id) { |
There was a problem hiding this comment.
updated to id != null
| @@ -254,6 +256,7 @@ function nvd3Vis(element, props) { | |||
| const container = element; | |||
| container.innerHTML = ''; | |||
| const activeAnnotationLayers = annotationLayers.filter(layer => layer.show); | |||
| const chartId = container.parentElement.id || null; | |||
There was a problem hiding this comment.
perhaps also check if parentElement is not null.
Also, do we want to prevent accidents if id is 0 which is falsy?
etr2460
force-pushed
the
erik-ritter--fix-tooltip-removal
branch
2 times, most recently
from
4e7c430
to
c360a8d
Compare
etr2460
force-pushed
the
erik-ritter--fix-tooltip-removal
branch
from
c360a8d
to
91aaac7
Compare
This was referenced Aug 6, 2019
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
* build: bump build-config * test: fix typings in mock data
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
When rerendering charts, we were removing all tooltips for every chart from the dom instead of just the one owned by the rerendering chart. This would break pages with multiple nvd3 charts on them (basically all superset dashboards). It can be easily reproed with dashboards with multiple tabs with the following steps:
I fixed this issue by uniquely identifying charts by the passed in id and applying this id to the tooltips as well. When rerendering or unmounting charts now, if an id was passed in then we only remove the tooltip belonging to that chart. If no ids are passed, then we retain the current behavior.