Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump nvd3 charts for tooltip fix #7994

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Bump nvd3 charts for tooltip fix #7994

merged 1 commit into from
Aug 6, 2019

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Aug 6, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Fixes erroneous removal of tooltips for charts on dashboards. see details at apache-superset/superset-ui-plugins#167

TEST PLAN

Use a dashboard with multiple tabs:

  1. hover over a chart on tab 1
  2. switch to tab 2
  3. resize the window, then resize it back to the original size
  4. switch back to tab 1
  5. still see tooltips on the previously hovered chart

ADDITIONAL INFORMATION

  • Has associated issue: Might be related to Line chart tooltips broken on Firefox #7822
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@graceguo-supercat @kristw @xtinec

mistercrunch
mistercrunch approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat graceguo-supercat merged commit 4543898 into apache:master Aug 6, 2019
@etr2460 etr2460 deleted the erik-ritter--bump-nvd3-charts branch August 6, 2019 22:26
etr2460 pushed a commit to airbnb/superset-fork that referenced this pull request Aug 6, 2019
Bump nvd3 charts for tooltip fix (apache#7994)
9f725b8
@etr2460 etr2460 mentioned this pull request Aug 6, 2019
Closed
12 tasks
etr2460 pushed a commit to airbnb/superset-fork that referenced this pull request Aug 6, 2019
Bump nvd3 charts for tooltip fix (apache#7994)
e15696f
etr2460 pushed a commit to airbnb/superset-fork that referenced this pull request Aug 6, 2019
Merge pull request #153 from airbnb/erik-ritter--cherrypick-7989-7994
bff897c 
Cherrypick apache#7989 and apache#7994 for tooltip fix
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etr2460 @mistercrunch @graceguo-supercat