Skip to content

Commit

Permalink
If we build a new image, we should run more than basic checks (#12070)
Browse files Browse the repository at this point in the history
This lead to bases such as in #11699 where despite there being changes,
and an image being build, the pre-commit tests were not being run.

(cherry picked from commit 8000ab7)
  • Loading branch information
ashb authored and potiuk committed Nov 14, 2020
1 parent 26d001f commit 6f64e98
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion scripts/ci/selective_ci_checks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,6 @@ if [[ ${image_build_needed} == "true" ]]; then
else
set_basic_checks_only "true"
fi
set_basic_checks_only "${image_build_needed}"
set_docs_build "${docs_build_needed}"
run_tests "${tests_needed}"
run_kubernetes_tests "${kubernetes_tests_needed}"

0 comments on commit 6f64e98

Please sign in to comment.