Enforce ESLint (JavaScript linting) with pre-commit hooks

[ryanahamilton]

The codebase has existing ESLint JavaScript linting rules configured, but they are not enforced (until now).

• I've added the eslint check to the pre-commit hooks.
• Refactored all of the existing files to be compliant with the rules so checks are passing.
• This is only being ran against external files (for now), as some additional refactoring will be required to get the inline scripting in order as well.
• I manually tested all of the webserver views that utilize these files and was unable to yield any console errors.

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

[mik-laj]

Does this eslint configuration meet the project style guide?
https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#follow-javascript-style-guide

[mik-laj]

Do we have Babel? I know there were some compatibility issues with older browsers.

[ryanahamilton]

@mik-laj yes this is running the same configuration as yarn run lint, it just has a narrower scope (doesn't run against HTML files yet).

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

[ashb]

/home/runner/work/airflow/airflow/airflow/www/static/js/ie.js
  22:8  error  Unable to resolve path to module 'url-search-params-polyfill'  import/no-unresolved

✖ 2 problems (1 error, 1 warning)


/home/runner/work/airflow/airflow/airflow/www/webpack.config.js
  20:25  error  Unable to resolve path to module 'webpack'                             import/no-unresolved
  22:32  error  Unable to resolve path to module 'webpack-manifest-plugin'             import/no-unresolved
  23:23  error  Unable to resolve path to module 'clean-webpack-plugin'                import/no-unresolved
  24:35  error  Unable to resolve path to module 'copy-webpack-plugin'                 import/no-unresolved
  25:38  error  Unable to resolve path to module 'mini-css-extract-plugin'             import/no-unresolved
  26:37  error  Unable to resolve path to module 'moment-locales-webpack-plugin'       import/no-unresolved
  27:41  error  Unable to resolve path to module 'optimize-css-assets-webpack-plugin'  import/no-unresolved

We might need to use something like https://www.npmjs.com/package/eslint-import-resolver-webpack ?

[ryanahamilton]

@ashb pre-commit wasn't including files outside of the /js/ directory locally—I think I just need to add an explicit argument to restrict to that directory—though it might be preferred to do as you suggest and check/fix all of the files?

[potiuk]

@ashb pre-commit wasn't including files outside of the /js/ directory locally—I think I just need to add an explicit argument to restrict to that directory—though it might be preferred to do as you suggest and check/fix all of the files?

Yeah - we are running pre-commit with --all-files switch in CI.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

[kaxil]

Rebased as Master was failing

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

[kaxil]

@ryanahamilton CI failed with the following:

ESLint............................................................................................................................Failed
- hook id: eslint
- exit code: 1

Error resolving webpackConfig Error: Cannot find module 'webpack'
Require stack:
- /home/runner/work/airflow/airflow/ai
.....

https://github.com/apache/airflow/pull/11699/checks?check_run_id=1292691649#step:7:176

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[kaxil]

Can you please rebase your PR on latest Master since we have applied Black and PyUpgrade on Master.

It will help if your squash your commits into single commit first so that there are less conflicts.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.