Skip to content

Commit

Permalink
Improve the error when DAG does not exist when running dag pause comm…
Browse files Browse the repository at this point in the history
…and (#13900)

When running `airflow dags unpause` with a DAG that does not exist, it
currently shows this error

```
root@6f086ba87198:/opt/airflow# airflow dags unpause example_bash_operatoredd
Traceback (most recent call last):
  File "/usr/local/bin/airflow", line 33, in <module>
    sys.exit(load_entry_point('apache-airflow', 'console_scripts', 'airflow')())
  File "/opt/airflow/airflow/__main__.py", line 40, in main
    args.func(args)
  File "/opt/airflow/airflow/cli/cli_parser.py", line 48, in command
    return func(*args, **kwargs)
  File "/opt/airflow/airflow/utils/cli.py", line 92, in wrapper
    return f(*args, **kwargs)
  File "/opt/airflow/airflow/cli/commands/dag_command.py", line 160, in dag_unpause
    set_is_paused(False, args)
  File "/opt/airflow/airflow/cli/commands/dag_command.py", line 170, in set_is_paused
    dag.set_is_paused(is_paused=is_paused)
AttributeError: 'NoneType' object has no attribute 'set_is_paused'
```

This commit changes the error to show a helpful error:

```
root@6f086ba87198:/opt/airflow# airflow dags unpause example_bash_operatoredd
DAG: example_bash_operatoredd does not exit in 'dag' table
```

(cherry picked from commit 8723b1f)
  • Loading branch information
kaxil committed Jan 27, 2021
1 parent e2fba14 commit 93e2438
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions airflow/cli/commands/dag_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,12 @@ def dag_unpause(args):

def set_is_paused(is_paused, args):
"""Sets is_paused for DAG by a given dag_id"""
DagModel.get_dagmodel(args.dag_id).set_is_paused(
is_paused=is_paused,
)
dag = DagModel.get_dagmodel(args.dag_id)

if not dag:
raise SystemExit(f"DAG: {args.dag_id} does not exit in 'dag' table")

dag.set_is_paused(is_paused=is_paused)

print("Dag: {}, paused: {}".format(args.dag_id, str(is_paused)))

Expand Down

0 comments on commit 93e2438

Please sign in to comment.