Improve the error when DAG does not exist when running dag pause command #13900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `airflow dags unpause` with a DAG that does not exist, it
currently shows this error
```
root@6f086ba87198:/opt/airflow# airflow dags unpause example_bash_operatoredd
Traceback (most recent call last):
File "/usr/local/bin/airflow", line 33, in <module>
sys.exit(load_entry_point('apache-airflow', 'console_scripts', 'airflow')())
File "/opt/airflow/airflow/__main__.py", line 40, in main
args.func(args)
File "/opt/airflow/airflow/cli/cli_parser.py", line 48, in command
return func(*args, **kwargs)
File "/opt/airflow/airflow/utils/cli.py", line 92, in wrapper
return f(*args, **kwargs)
File "/opt/airflow/airflow/cli/commands/dag_command.py", line 160, in dag_unpause
set_is_paused(False, args)
File "/opt/airflow/airflow/cli/commands/dag_command.py", line 170, in set_is_paused
dag.set_is_paused(is_paused=is_paused)
AttributeError: 'NoneType' object has no attribute 'set_is_paused'
```
This commit changes the error to show a helpful error:
```
root@6f086ba87198:/opt/airflow# airflow dags unpause example_bash_operatoredd
DAG: example_bash_operatoredd does not exit in 'dag' table
```
ryanahamilton
approved these changes
Jan 26, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
kaxil
added a commit
that referenced
this pull request
Jan 27, 2021
…and (#13900) When running `airflow dags unpause` with a DAG that does not exist, it currently shows this error ``` root@6f086ba87198:/opt/airflow# airflow dags unpause example_bash_operatoredd Traceback (most recent call last): File "/usr/local/bin/airflow", line 33, in <module> sys.exit(load_entry_point('apache-airflow', 'console_scripts', 'airflow')()) File "/opt/airflow/airflow/__main__.py", line 40, in main args.func(args) File "/opt/airflow/airflow/cli/cli_parser.py", line 48, in command return func(*args, **kwargs) File "/opt/airflow/airflow/utils/cli.py", line 92, in wrapper return f(*args, **kwargs) File "/opt/airflow/airflow/cli/commands/dag_command.py", line 160, in dag_unpause set_is_paused(False, args) File "/opt/airflow/airflow/cli/commands/dag_command.py", line 170, in set_is_paused dag.set_is_paused(is_paused=is_paused) AttributeError: 'NoneType' object has no attribute 'set_is_paused' ``` This commit changes the error to show a helpful error: ``` root@6f086ba87198:/opt/airflow# airflow dags unpause example_bash_operatoredd DAG: example_bash_operatoredd does not exit in 'dag' table ``` (cherry picked from commit 8723b1f)
kaxil
added a commit
that referenced
this pull request
Feb 4, 2021
…and (#13900) When running `airflow dags unpause` with a DAG that does not exist, it currently shows this error ``` root@6f086ba87198:/opt/airflow# airflow dags unpause example_bash_operatoredd Traceback (most recent call last): File "/usr/local/bin/airflow", line 33, in <module> sys.exit(load_entry_point('apache-airflow', 'console_scripts', 'airflow')()) File "/opt/airflow/airflow/__main__.py", line 40, in main args.func(args) File "/opt/airflow/airflow/cli/cli_parser.py", line 48, in command return func(*args, **kwargs) File "/opt/airflow/airflow/utils/cli.py", line 92, in wrapper return f(*args, **kwargs) File "/opt/airflow/airflow/cli/commands/dag_command.py", line 160, in dag_unpause set_is_paused(False, args) File "/opt/airflow/airflow/cli/commands/dag_command.py", line 170, in set_is_paused dag.set_is_paused(is_paused=is_paused) AttributeError: 'NoneType' object has no attribute 'set_is_paused' ``` This commit changes the error to show a helpful error: ``` root@6f086ba87198:/opt/airflow# airflow dags unpause example_bash_operatoredd DAG: example_bash_operatoredd does not exit in 'dag' table ``` (cherry picked from commit 8723b1f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
airflow dags unpausewith a DAG that does not exist, itcurrently shows this error
This commit changes the error to show a helpful error:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.