Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a upgrade check rule to update [scheduler] max_threads config #12672

Closed
kaxil opened this issue Nov 27, 2020 · 2 comments
Closed

Create a upgrade check rule to update [scheduler] max_threads config #12672

kaxil opened this issue Nov 27, 2020 · 2 comments
Labels
area:upgrade Facilitating migration to a newer version of Airflow kind:task A task that needs to be completed as part of a larger issue upgrade-check upgrade-check CLI
Milestone
Airflow Upgrade C...

Comments

@kaxil
Copy link
Member

kaxil commented Nov 27, 2020 •
edited
Loading

This config was renamed in #12605 (comment)

The rule should suggest to change config from [scheduler] max_threads to [scheduler] parsing_processes in 1.10.14
@kaxil kaxil added kind:bug This is a clearly a bug area:upgrade Facilitating migration to a newer version of Airflow upgrade-check upgrade-check CLI labels Nov 27, 2020
@kaxil kaxil mentioned this issue Nov 27, 2020
Merged
@kaxil kaxil removed the kind:bug This is a clearly a bug label Dec 8, 2020
@vikramkoka vikramkoka added the kind:task A task that needs to be completed as part of a larger issue label Feb 9, 2021
@Seltsamsel Seltsamsel mentioned this issue Mar 20, 2021
Merged
kaxil pushed a commit that referenced this issue Mar 23, 2021
@Seltsamsel
Upgrade rule to suggest to rename max_threads to parsing_processes (#…
42dafd2 
…14913)

This adds an upgrade rule as described in #12672 to rename the max_threads configuration to parsing_processes.

I created this rule on the example of the LoggingConfigurationRule, which doesn't suggest any changes if the old configuration exists but has the default value. I assume, that the idea behind this is, that if the configuration is not set by the user, a default configuration is taken. However, if a user explicitly copied the default configuration in his or her own configuration, in my opinion, a change should be suggested but isn't. But maybe I misunderstood something.

closes #12672
@Seltsamsel
Copy link
Contributor

This should be resolved by #14913 .

@kaxil
Copy link
Member Author

kaxil commented Mar 23, 2021

closed by #14913

@kaxil kaxil closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:upgrade Facilitating migration to a newer version of Airflow kind:task A task that needs to be completed as part of a larger issue upgrade-check upgrade-check CLI
Projects
None yet
Milestone
Airflow Upgrade Check - 1.4.0
Development

No branches or pull requests
4 participants
@ashb @kaxil @vikramkoka @Seltsamsel