Rename [scheduler] max_threads to [scheduler] parsing_processes
#12605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Airflow 2.0, `max_threads` config under `[scheduler]` section has been renamed to `parsing_processes`. This is to align the name with the actual code where the Scheduler launches the number of processes defined by `[scheduler] parsing_processes` to Parse DAG files, calculates next DagRun date for each DAG, serialize them and store them in the DB.
boring-cyborg
bot
added
area:dev-tools
area:Scheduler
ashb
approved these changes
Nov 25, 2020
github-actions
bot
added
the
full tests needed
|
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! |
turbaszek
reviewed
Nov 25, 2020
| This is to align the name with the actual code where the Scheduler launches the number of processes defined by | ||
| `[scheduler] parsing_processes` to Parse DAG files, calculates next DagRun date for each DAG, | ||
| serialize them and store them in the DB. | ||
|
|
There was a problem hiding this comment.
Should we add this to upgrade check?
There was a problem hiding this comment.
We should yeah, I will create a GH issue for it
There was a problem hiding this comment.
I think we need a new "class" of upgrade checks:
You can make these changes now, and it will run on 1.10.13
and
You'll need to change this, but it won't work on 1.10.13.
kaxil
added a commit
that referenced
this pull request
Nov 30, 2020
…12605) From Airflow 1.10.14, `max_threads` config under `[scheduler]` section has been renamed to `parsing_processes`. This is to align the name with the actual code where the Scheduler launches the number of processes defined by `[scheduler] parsing_processes` to Parse DAG files, calculates next DagRun date for each DAG, serialize them and store them in the DB. (cherry picked from commit 4861344)
kaxil
added a commit
that referenced
this pull request
Dec 3, 2020
…12605) From Airflow 1.10.14, `max_threads` config under `[scheduler]` section has been renamed to `parsing_processes`. This is to align the name with the actual code where the Scheduler launches the number of processes defined by `[scheduler] parsing_processes` to Parse DAG files, calculates next DagRun date for each DAG, serialize them and store them in the DB. (cherry picked from commit 4861344)
ashb
pushed a commit
that referenced
this pull request
Dec 3, 2020
…12605) From Airflow 1.10.14, `max_threads` config under `[scheduler]` section has been renamed to `parsing_processes`. This is to align the name with the actual code where the Scheduler launches the number of processes defined by `[scheduler] parsing_processes` to Parse DAG files, calculates next DagRun date for each DAG, serialize them and store them in the DB. (cherry picked from commit 4861344)
AntonyRileyAtVerto
pushed a commit
to vertoanalytics/incubator-airflow
that referenced
this pull request
Feb 2, 2021
- BugFix: Tasks with ``depends_on_past`` or ``task_concurrency`` are stuck (apache#12663) - Fix issue with empty Resources in executor_config (apache#12633) - Fix: Deprecated config ``force_log_out_after`` was not used (apache#12661) - Fix empty asctime field in JSON formatted logs (apache#10515) - [AIRFLOW-2809] Fix security issue regarding Flask SECRET_KEY (apache#3651) - [AIRFLOW-2884] Fix Flask SECRET_KEY security issue in www_rbac (apache#3729) - [AIRFLOW-2886] Generate random Flask SECRET_KEY in default config (apache#3738) - Add missing comma in setup.py (apache#12790) - Bugfix: Unable to import Airflow plugins on Python 3.8 (apache#12859) - Fix setup.py missing comma in ``setup_requires`` (apache#12880) - Don't emit first_task_scheduling_delay metric for only-once dags (apache#12835) - Update setup.py to get non-conflicting set of dependencies (apache#12636) - Rename ``[scheduler] max_threads`` to ``[scheduler] parsing_processes`` (apache#12605) - Add metric for scheduling delay between first run task & expected start time (apache#9544) - Add new-style 2.0 command names for Airflow 1.10.x (apache#12725) - Add Kubernetes cleanup-pods CLI command for Helm Chart (apache#11802) - Don't let webserver run with dangerous config (apache#12747) - Replace pkg_resources with importlib.metadata to avoid VersionConflict errors (apache#12694) - Clarified information about supported Databases
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
…pache#12605) From Airflow 1.10.14, `max_threads` config under `[scheduler]` section has been renamed to `parsing_processes`. This is to align the name with the actual code where the Scheduler launches the number of processes defined by `[scheduler] parsing_processes` to Parse DAG files, calculates next DagRun date for each DAG, serialize them and store them in the DB. (cherry picked from commit 4861344)
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Airflow 2.0,
max_threadsconfig under[scheduler]section has been renamed toparsing_processes.This is to align the name with the actual code where the Scheduler launches the number of processes defined by
[scheduler] parsing_processesto Parse DAG files, calculates next DagRun date for each DAG,serialize them and store them in the DB.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.