Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate React js files to typescript #24350

Closed
2 tasks done
bbovenzi opened this issue Jun 9, 2022 · 0 comments · Fixed by #26112
Closed
2 tasks done

Migrate React js files to typescript #24350

bbovenzi opened this issue Jun 9, 2022 · 0 comments · Fixed by #26112
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests

Comments

@bbovenzi
Copy link
Contributor

bbovenzi commented Jun 9, 2022

Description

We added typescript support in #24337. Now, we should work on migrating all the react code over to typescript.

We could migrate other js files too, but I think the react logic in /static/js/grid is the best starting point as we will need to re-do many other pages later on.

This would be best spread across multiple PRs even to make it easy to test and review.

Use case/motivation

Type checking should help us catch issues early and make it easier to be confident in the changes we make.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@bbovenzi bbovenzi added kind:feature Feature Requests area:UI Related to UI/UX. For Frontend Developers. labels Jun 9, 2022
@bbovenzi bbovenzi mentioned this issue Jun 16, 2022
Merged
This was referenced Jul 15, 2022
Merged
Merged
Merged
Merged
@pierrejeambrun pierrejeambrun mentioned this issue Jul 24, 2022
Merged
@pierrejeambrun pierrejeambrun mentioned this issue Aug 22, 2022
Merged
@bbovenzi bbovenzi mentioned this issue Sep 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate last react js files to typescript astronomer/airflow
1 participant
@bbovenzi