Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript #24337

Merged
merged 6 commits into from
Jun 9, 2022
Merged

Add typescript #24337

merged 6 commits into from
Jun 9, 2022

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Jun 8, 2022

Add typescript support for the current UI project in /airflow/www.

  • Include type checking as part of the yarn lint checks
  • Add example .tsx and .test.tsx files with the Time component and fix some associated typing issues

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jun 8, 2022
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!

I guess that ts is the new standard from now on ? (Also updating existing code each time we have the opportunity to)

@bbovenzi
Copy link
Contributor Author

bbovenzi commented Jun 8, 2022

Really nice!

I guess that ts is the new standard from now on ? (Also updating existing code each time we have the opportunity to)

Yep. That's the plan. We can migrate js files over time and across PRs.

@@ -5,6 +5,32 @@
"rules": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add typescript-eslint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was playing around with it. Let me make sure it's in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 8, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr
Copy link
Member

uranusjr commented Jun 9, 2022

🎉

@uranusjr uranusjr merged commit 74ac9f7 into apache:main Jun 9, 2022
@uranusjr uranusjr deleted the add-typescript branch June 9, 2022 09:54
@potiuk
Copy link
Member

potiuk commented Jun 9, 2022

Cool! Maybe finally some chance to contribute to the UI part :)

@bbovenzi bbovenzi added this to the Airflow 2.3.3 milestone Jun 28, 2022
ephraimbuddy pushed a commit that referenced this pull request Jun 29, 2022
(cherry picked from commit 74ac9f7)
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jun 30, 2022
@ephraimbuddy ephraimbuddy added type:misc/internal Changelog: Misc changes that should appear in change log and removed changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) labels Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants