Upgrade API files to typescript #25098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
boring-cyborg
bot
added
area:UI
mik-laj
reviewed
Jul 16, 2022
bbovenzi
reviewed
Jul 18, 2022
|
Now that the API type generation is merged do you want to rebase the branch? |
pierrejeambrun
force-pushed
the
upgrade-api-hooks-to-ts
branch
from
d46bce5
to
947dd1d
Compare
|
@bbovenzi Of course the branch is rebased :) |
potiuk
force-pushed
the
upgrade-api-hooks-to-ts
branch
from
947dd1d
to
60ee210
Compare
|
Rebased to account for "Werkzeug" fix |
pierrejeambrun
force-pushed
the
upgrade-api-hooks-to-ts
branch
4 times, most recently
from
fbe26ae
to
067c203
Compare
pierrejeambrun
force-pushed
the
upgrade-api-hooks-to-ts
branch
from
3b5386e
to
0d00add
Compare
pierrejeambrun
requested review from
bbovenzi and
mik-laj
and removed request for
ryanahamilton,
ashb,
bbovenzi and
mik-laj
pierrejeambrun
changed the title
pierrejeambrun
changed the title
bbovenzi
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move files under
js/apito typescript.related: #24350
@bbovenzi As discussed, here is a draft with only a few files (Migrations) updated.I tried to use as many types as possible from the API generated ones. Some of the hooks use endpoints from
views.pythat are not exposed in the public API, we still need to make our own type for them.As Brent suggested, there is also a very minimal
URLSearchParamsWrapperto avoid manually casting to String everything.