Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task Duration Missing from the Graph View Tool-tip for Running Tasks #8311

Closed
shane-graham opened this issue Apr 15, 2020 · 7 comments
Closed

Task Duration Missing from the Graph View Tool-tip for Running Tasks #8311

shane-graham opened this issue Apr 15, 2020 · 7 comments
Assignees
@fuyi
Labels
area:webserver Webserver related Issues kind:bug This is a clearly a bug

Comments

@shane-graham
Copy link

shane-graham commented Apr 15, 2020 •
edited
Loading

Apache Airflow version: 1.10.10

Environment:

  • Cloud provider or hardware configuration: AWS EC2 m5.2xlarge
  • OS (e.g. from /etc/os-release): Ubuntu 18.04.4 LTS
  • Kernel (e.g. uname -a): Linux 4.15.0-1063-aws Adding pre and post execute hooks to BaseOperator #67-Ubuntu SMP Mon Mar 2 07:24:29 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
  • Install tools: Python 3.7.7/Pip in a virtual environment
  • Others: RBAC UI, on a standalone server with the LocalExecutor running a PostgreSQL repository

What happened: The Graph View tool-tip does not display the duration of running tasks while the Tree View does. In addition, the Graph View shows "Invalid Date" for the "Ended:" field while the Tree View displays the current datetime.

What you expected to happen: The Graph View should show the same date and duration information as the Tree View for running tasks.

How to reproduce it: While a DAG is executing, examine the tool-tips in both the Tree View and Graph View pages.

image
@shane-graham shane-graham added the kind:bug This is a clearly a bug label Apr 15, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 15, 2020

Thanks for opening your first issue here! Be sure to follow the issue template!

@ashb ashb added the area:webserver Webserver related Issues label Apr 15, 2020
@zachliu
Copy link
Contributor

zachliu commented Apr 30, 2020

upgraded to 1.10.10 two weeks ago, just noticed this issue 😅

@fuyi
Copy link
Contributor

fuyi commented May 1, 2020

I start working on this bug, have already reproduced the issue and start fixing it. will submit a PR soon

@XD-DENG
Copy link
Member

XD-DENG commented May 1, 2020

Thanks @fuyi for taking up this

@fuyi fuyi mentioned this issue May 1, 2020
Merged
6 tasks
@fuyi
Copy link
Contributor

fuyi commented May 1, 2020

PR is available at: #8675

@ipeluffo
Copy link
Contributor

ipeluffo commented May 7, 2020 •
edited
Loading

I noticed this issue also in (some) tasks on finished DAGs. Has anyone else noticed this?
Screenshot 2020-05-07 at 18 10 31
Screenshot 2020-05-07 at 18 09 54

fuyi pushed a commit to fuyi/airflow that referenced this issue Jun 7, 2020
show correct duration on graph view for running task (apache#8311)
f31be7d
fuyi pushed a commit to fuyi/airflow that referenced this issue Jun 7, 2020
fix invalid end date (apache#8311)
dd0d8b9
ashb added a commit that referenced this issue Jun 27, 2020
@fuyi @ashb
show correct duration on graph view for running task (#8311) (#8675)
118ea2f 
* show correct duration on graph view for running task (#8311)

* fix invalid end date  (#8311)

* Update airflow/www/static/js/task-instances.js

Co-authored-by: Ash Berlin-Taylor <[email protected]>

Co-authored-by: Ash Berlin-Taylor <[email protected]>
kaxil pushed a commit to kaxil/airflow that referenced this issue Jun 27, 2020
@fuyi @ashb @kaxil
show correct duration on graph view for running task (apache#8311) (a…
79a6a21 
…pache#8675)

* show correct duration on graph view for running task (apache#8311)

* fix invalid end date  (apache#8311)

* Update airflow/www/static/js/task-instances.js

Co-authored-by: Ash Berlin-Taylor <[email protected]>

Co-authored-by: Ash Berlin-Taylor <[email protected]>
kaxil pushed a commit that referenced this issue Aug 12, 2020
@fuyi @ashb @kaxil
show correct duration on graph view for running task (#8311) (#8675)
c374a80 
* fix invalid end date  (#8311)

* Update airflow/www/static/js/task-instances.js

Co-authored-by: Ash Berlin-Taylor <[email protected]>
kaxil pushed a commit that referenced this issue Aug 15, 2020
@fuyi @ashb @kaxil
show correct duration on graph view for running task (#8311) (#8675)
277f33c 
* fix invalid end date  (#8311)

* Update airflow/www/static/js/task-instances.js

Co-authored-by: Ash Berlin-Taylor <[email protected]>
@eladkal
Copy link
Contributor

eladkal commented Jan 28, 2021

fixed in #8675

@eladkal eladkal closed this as completed Jan 28, 2021
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this issue Mar 5, 2021
@fuyi @ashb
show correct duration on graph view for running task (apache#8311) (a…
5bc93ec 
…pache#8675)

* fix invalid end date  (apache#8311)

* Update airflow/www/static/js/task-instances.js

Co-authored-by: Ash Berlin-Taylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fuyi fuyi

Labels
area:webserver Webserver related Issues kind:bug This is a clearly a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ashb @fuyi @ipeluffo @XD-DENG @zachliu @eladkal @shane-graham