show correct duration on graph view for running task (#8311) #8675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I may point Invalid date is also misleading. There is nothing invalid here. It just didn't finish so there is no date in Ended. |
|
Hi @ashb , Do you have any comment for this PR? : ) |
ashb
requested changes
Jun 5, 2020
|
Hi @ashb,
|
|
@ashb Do you have more comments? Can I get approval from you : ) |
ashb
reviewed
Jun 21, 2020
Co-authored-by: Ash Berlin-Taylor <[email protected]>
|
Thanks for comment @ashb , The screenshot is updated now |
ashb
approved these changes
Jun 27, 2020
|
Awesome work, congrats on your first merged pull request! |
kaxil
pushed a commit
to kaxil/airflow
that referenced
this pull request
Jun 27, 2020
…pache#8675) * show correct duration on graph view for running task (apache#8311) * fix invalid end date (apache#8311) * Update airflow/www/static/js/task-instances.js Co-authored-by: Ash Berlin-Taylor <[email protected]> Co-authored-by: Ash Berlin-Taylor <[email protected]>
kaxil
pushed a commit
that referenced
this pull request
Aug 12, 2020
* fix invalid end date (#8311) * Update airflow/www/static/js/task-instances.js Co-authored-by: Ash Berlin-Taylor <[email protected]>
kaxil
pushed a commit
that referenced
this pull request
Aug 15, 2020
* fix invalid end date (#8311) * Update airflow/www/static/js/task-instances.js Co-authored-by: Ash Berlin-Taylor <[email protected]>
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
…pache#8675) * fix invalid end date (apache#8311) * Update airflow/www/static/js/task-instances.js Co-authored-by: Ash Berlin-Taylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aim to fix issue #8311
Idea:
Tooltip before fix:
Tooltip after fix:
The original bug of not showing duration at all on graph view is not the case on master branch, but, the value shows in the tooltip is not correct, since it is read from database and scheduler doesn't update duration frequently to reflect the actual duration till current timestamp for running tasks.
Note: The bug reported in issue 8311 is on v1.10.10 but this PR is based on master branch. Since there are fundamental change between master and v1.10.10 branch, separate PR might be needed to for v1.10.10.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.