Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entrypoint does not take into account _CMD variables for DB and Broker configurations #8705

Closed
NBardelot opened this issue May 4, 2020 · 1 comment · Fixed by #12411
Closed

Entrypoint does not take into account _CMD variables for DB and Broker configurations #8705

NBardelot opened this issue May 4, 2020 · 1 comment · Fixed by #12411
Assignees
@potiuk
Labels
area:production-image Production image improvements and fixes kind:feature Feature Requests
Milestone
Airflow 1.10.13

Comments

@NBardelot
Copy link
Contributor

The entrypoint manages the two variables AIRFLOW__CORE__SQL_ALCHEMY_CONN and AIRFLOW__CELERY__BROKER_URL but does not take into account the fact that those configurations can be overriden by AIRFLOW__CORE__SQL_ALCHEMY_CONN_CMD and AIRFLOW__CELERY__BROKER_URL_CMD which is very useful when providing the connections to those endpoints using Swarm/Kubernetes secrets.

The Dockerfile and its entrypoint come from the 2.0 refactoring (master branch) and have been backported to the 1.10 branch. Since the _CMD behaviour is present in the 1.10 stable branch the fix should be done there.
@NBardelot NBardelot added the kind:bug This is a clearly a bug label May 4, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented May 4, 2020

Thanks for opening your first issue here! Be sure to follow the issue template!

@potiuk potiuk added area:production-image Production image improvements and fixes kind:feature Feature Requests and removed kind:bug This is a clearly a bug labels May 4, 2020
@potiuk potiuk self-assigned this May 4, 2020
@NBardelot NBardelot mentioned this issue May 4, 2020
Closed
NBardelot added a commit to NBardelot/airflow that referenced this issue May 4, 2020
@NBardelot
FIX Entrypoint and _CMD config variables (apache#8705)
e5336a4 
The entrypoint manages the two variables AIRFLOW__CORE__SQL_ALCHEMY_CONN and AIRFLOW__CELERY__BROKER_URL but does not take into account the fact that those configurations can be overriden by AIRFLOW__CORE__SQL_ALCHEMY_CONN_CMD and AIRFLOW__CELERY__BROKER_URL_CMD which is very useful when providing the connections to those endpoints using Swarm/Kubernetes secrets.

The Dockerfile and its entrypoint come from the 2.0 refactoring (master branch) and have been backported to the 1.10 branch. Since the _CMD behaviour is present in the 1.10 stable branch the fix should be done there.
@NBardelot NBardelot mentioned this issue May 4, 2020
Open
@potiuk potiuk added this to the Airflow 1.10.11 milestone Jun 26, 2020
@kaxil kaxil mentioned this issue Nov 17, 2020
Merged
kaxil added a commit to astronomer/airflow that referenced this issue Nov 17, 2020
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables
f3361f1 
closes apache#8705

Co-Authored-By: Noël Bardelot <[email protected]>
kaxil added a commit that referenced this issue Nov 18, 2020
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
f4851f7 
closes #8705

Co-Authored-By: Noël Bardelot <[email protected]>
kaxil added a commit that referenced this issue Nov 18, 2020
@kaxil
Fix Entrypoint and _CMD config variables (#12411)
62d24f8 
closes #8705

Co-Authored-By: Noël Bardelot <[email protected]>
(cherry picked from commit f4851f7)
kaxil added a commit that referenced this issue Nov 18, 2020
@kaxil
Fix Entrypoint and _CMD config variables (#12411)
7f9105a 
closes #8705

Co-Authored-By: Noël Bardelot <[email protected]>
(cherry picked from commit f4851f7)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this issue Mar 5, 2021
@kaxil
Fix Entrypoint and _CMD config variables (apache#12411)
8fdb4e4 
closes apache#8705

Co-Authored-By: Noël Bardelot <[email protected]>
(cherry picked from commit f4851f7)
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 9, 2021
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
35c7122 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
(cherry picked from commit f4851f7d75d45f85204e3ceba77c8b8e479a1d7c)
GitOrigin-RevId: 7f9105a903976c57e0cd69815be5d673cc4f1f78
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 9, 2021
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
b7d999f 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
(cherry picked from commit f4851f7d75d45f85204e3ceba77c8b8e479a1d7c)
GitOrigin-RevId: 7f9105a903976c57e0cd69815be5d673cc4f1f78
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 15, 2021
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
32bbf42 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 17, 2021
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
a51a402 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 23, 2021
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
e5aeb9e 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Nov 27, 2021
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
225a5e0 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Mar 10, 2022
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
7caa33f 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 4, 2022
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
fa1c603 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 7, 2022
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
1013bd0 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jul 9, 2022
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
8649426 
closes apache/airflow#8705

Co-Authored-By: No?l Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Aug 27, 2022
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
d6fa9ad 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Oct 4, 2022
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
5b08adb 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Oct 7, 2022
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
fdfc433 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Dec 7, 2022
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
d72503f 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jan 27, 2023
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
b1437e6 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this issue Sep 12, 2024
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
e25780c 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this issue Sep 12, 2024
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
366b114 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 17, 2024
@kaxil @NBardelot
Fix Entrypoint and _CMD config variables (#12411)
72a3f53 
closes apache/airflow#8705

Co-Authored-By: Noël Bardelot <[email protected]>
GitOrigin-RevId: f4851f7d75d45f85204e3ceba77c8b8e479a1d7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@potiuk potiuk

Labels
area:production-image Production image improvements and fixes kind:feature Feature Requests
Projects
None yet
Milestone
Airflow 1.10.13
Development

Successfully merging a pull request may close this issue.

Fix Entrypoint and _CMD config variables astronomer/airflow
3 participants
@potiuk @kaxil @NBardelot