FIX Entrypoint and _CMD config variables (#8705) #8707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entrypoint manages the two variables AIRFLOW__CORE__SQL_ALCHEMY_CONN and AIRFLOW__CELERY__BROKER_URL but does not take into account the fact that those configurations can be overriden by AIRFLOW__CORE__SQL_ALCHEMY_CONN_CMD and AIRFLOW__CELERY__BROKER_URL_CMD which is very useful when providing the connections to those endpoints using Swarm/Kubernetes secrets. The Dockerfile and its entrypoint come from the 2.0 refactoring (master branch) and have been backported to the 1.10 branch. Since the _CMD behaviour is present in the 1.10 stable branch the fix should be done there.
NBardelot
force-pushed
the
FIX-8705-entrypoint-and-CMD-config
branch
from
9dcb29e
to
e5336a4
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
|
Unstale :) |
stale
bot
removed
the
stale
|
Hey @NBardelot I see I missed that one. Would you mind rebasing ? |
potiuk
added
area:production-image
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
|
Unstale. |
stale
bot
removed
the
stale
|
unstale again |
|
@NBardelot - are you going to complete that one? |
|
Created another PR #12411 to target master and will be cherry-picked. Added the original author as co-author too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #8705