-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix airflow-webserer startup errors (v1-10-test) #10047
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit fd62b1c)
When quick-fixing Python 3.8.4 error #9820 PYTHON_BASE_IMAGE_VERSION variable was added but it was initialized too early in Breeze and it took the default version of Python rather than the one chosen by --python switch. This caused the generated requirements (locally by Breeze only) to generate wrong set of requirements and images built locally for different python versions were based on default Python version, not the one chosen by --python switch. (cherry picked from commit 7b9e8e0)
If a task is skipped by BranchPythonOperator, BaseBranchOperator or ShortCircuitOperator and the user then clears the skipped task later, it'll execute. This is probably not the right behaviour. This commit changes that so it will be skipped again. This can be ignored by running the task again with "Ignore Task Deps" override. (cherry picked from commit 1cdab56)
) So far tests were not triggered when only requirements changed, but this is quite needed in fact. (cherry picked from commit 72abf82)
Currently there is "unbound" variable error printed in CI logs because of that. (cherry picked from commit 69f82e6)
Reviewed the scripts and removed some of the old unused ones. (cherry picked from commit faec41e)
* we come back to idea of having one CI workflow * cancel and openapi are incorporated into that CI workflow * cancel retrieves workflow id automatically (works for forks) * static checks are now merged into one job * less dependencies between jobs so that waiting is minimised * better name for check if tests should be run * separated out script for tests should be run check (cherry picked from commit 496ed6f)
* Constraint files are now maintained automatically * No need to generate requirements when setup.py changes * requirements are kept in separate orphan branches not in main repo * merges to master verify if latest requirements are working and push tested requirements to orphaned branches * we keep history of requirement changes and can label them individually for each version (by constraint-1.10.n tag name) * consistently changed all references to be 'constraints' not 'requirements' (cherry picked from commit de9eaeb)
Remove the checklist of always checked points. (cherry picked from commit 7dd5c11)
(cherry picked from commit 508d7d2)
(cherry picked from commit e86d753)
Since we are mountign tmp dir now to inside container, some of the remnants of what's going on inside remains after exit. This is particularly bad if you are using tmux (some of the directories remaining there prevent tmux from re-run) This change cleans up /tmp directory on exit from Breeze command. It does it from inside container so that we clean up all root-owned files without sudo. (cherry picked from commit a9c871b)
(cherry picked from commit 560e0b5)
* Fix PodGenerator to handle Kubernetes resources In Airflow 1.10.11, `namespaced['resources'] = resources` is missing. This PR improves the definition of pod resources, `requests` and `limits` are optional. * Make it working in 2.7 * Add limit_gpu and fix ephemeral-storage keys * Fix flake8 Co-authored-by: Riccardo Bini <[email protected]>
fix airflow-webserer startup errors if airflow.api.auth.backend.kerberos_auth enabled
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
@Kurganov Can I ask for a review? |
done |
kaxil
pushed a commit
that referenced
this pull request
Aug 14, 2020
fix airflow-webserer startup errors if airflow.api.auth.backend.kerberos_auth enabled (cherry picked from commit 87b495b)
Has been cherry-picked to v1-10-test: 8e11423 |
kaxil
pushed a commit
that referenced
this pull request
Aug 14, 2020
fix airflow-webserer startup errors if airflow.api.auth.backend.kerberos_auth enabled (cherry picked from commit 87b495b)
kaxil
pushed a commit
that referenced
this pull request
Aug 14, 2020
fix airflow-webserer startup errors if airflow.api.auth.backend.kerberos_auth enabled (cherry picked from commit 87b495b)
kaxil
pushed a commit
that referenced
this pull request
Aug 15, 2020
fix airflow-webserer startup errors if airflow.api.auth.backend.kerberos_auth enabled (cherry picked from commit 87b495b)
kaxil
pushed a commit
that referenced
this pull request
Aug 15, 2020
fix airflow-webserer startup errors if airflow.api.auth.backend.kerberos_auth enabled (cherry picked from commit 87b495b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix airflow-webserer startup errors
if airflow.api.auth.backend.kerberos_auth is enabled