Fix chart network policies definion and compliance

[FloChehab]

Hello @mik-laj,

While I was adding support for an external redis to the chart I had issues with your latest changes regarding schema validation.

Here are the fixes.

Followup to #12003:

• Some network policies & ingress are not valid
  against the jsonschema (empty values mostly)
• Some network policies conditionnal definitions
  were incorrect

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

[mik-laj]

I don't understand how to use option extraNetworkPolicies in NetworkPolicy. I tried a similar policy in helm / charts and couldn't find anything similar. It seems to me that we should think a little more about what these policies should do.
https://github.com/helm/charts/search?p=2&q=NetworkPolicy

[FloChehab]

I am not that familiar with networkPolicies so no real opinion on this.

Also:

• There seems to have been a discussion around this on the helm/chart repo: Proposed NetworkPolicy best practices helm/charts#4067
• those extraNetworkPolicies don't seem to have ever existed on astronomer's chart (except for pgbouncer) ; so maybe we can ask the ones who participated in Add Production Helm chart support #8777 ?

[mik-laj]

@thesuperzapper Do you have any experience with this? Can you help us please?

[thesuperzapper]

@mik-laj I don't know what the creator of this specific PR was trying to achieve, but from context, its just a way for users to specify things under from using a list value, for example:

webserver:
  extraNetworkPolicies:
    - ipBlock:
        cidr: 172.17.0.0/16
        except:
          - 172.17.1.0/24
    - namespaceSelector:
        matchLabels:
          project: myproject
    - podSelector:
        matchLabels:
          role: frontend

You can read about NetworkPolicy here: https://kubernetes.io/docs/concepts/services-networking/network-policies/

But this is just another case where there needs to be significant documentation updates for this chart before it's ready for normal users.

[kaxil]

Can you please rebased your PR on latest Master since we have applied Black and PyUpgrade on Master.

It will help if your squash your commits into single commit first so that there are less conflicts.

[FloChehab]

Can you please rebased your PR on latest Master since we have applied Black and PyUpgrade on Master.

It will help if your squash your commits into single commit first so that there are less conflicts.

Done.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[FloChehab]

Merged in master through #12010