Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All k8s object must comply with JSON Schema #12003

Merged
merged 2 commits into from
Oct 31, 2020

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Oct 31, 2020

Depends on: https://github.com/apache/airflow/pull/12002/files


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Oct 31, 2020
@mik-laj
Copy link
Member Author

mik-laj commented Oct 31, 2020

CC: @FloChehab

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ - this is what switching to pytest-based tests for k8s enabled

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Oct 31, 2020
@github-actions
Copy link

The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!

@potiuk potiuk merged commit 3c85c2c into apache:master Oct 31, 2020
@potiuk potiuk deleted the json-schema branch October 31, 2020 17:51
szn pushed a commit to szn/airflow that referenced this pull request Nov 1, 2020
* All k8s resources should have global labels

* All k8s object must comply with JSON Schema
FloChehab pushed a commit to MeilleursAgents/airflow that referenced this pull request Nov 7, 2020
Followup to apache#12003:
* Some network policies & ingress are not valid
  against the jsonschema (empty values mostly)
* Some network policies conditionnal definitions
  were incorrect
potiuk pushed a commit that referenced this pull request Nov 15, 2020
* All k8s resources should have global labels

* All k8s object must comply with JSON Schema

(cherry picked from commit 3c85c2c)
@potiuk potiuk added the type:improvement Changelog: Improvements label Nov 15, 2020
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 15, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
* All k8s resources should have global labels

* All k8s object must comply with JSON Schema

(cherry picked from commit 3c85c2c)
potiuk pushed a commit that referenced this pull request Nov 16, 2020
* All k8s resources should have global labels

* All k8s object must comply with JSON Schema

(cherry picked from commit 3c85c2c)
kaxil pushed a commit that referenced this pull request Nov 18, 2020
* All k8s resources should have global labels

* All k8s object must comply with JSON Schema

(cherry picked from commit 3c85c2c)
FloChehab pushed a commit to MeilleursAgents/airflow that referenced this pull request Jan 8, 2021
Followup to apache#12003:
* Some network policies & ingress are not valid
  against the jsonschema (empty values mostly)
* Some network policies conditionnal definitions
  were incorrect
mik-laj pushed a commit that referenced this pull request Jan 9, 2021
* Fix chart network policies definion and compliance

Followup to #12003:
* Some network policies & ingress are not valid
  against the jsonschema (empty values mostly)
* Some network policies conditionnal definitions
  were incorrect

* Support external redis instance in helm chart

The main objective here is to support the use
of an external redis instance in the helm chart.
The values 'data.brokerUrl' and
'data.brokerUrlSecretName' are added and
templates are updated.

This support is added with no breaking changes
(hopefully); only the redis.brokerURLSecretName
value is removed, but it wasn't actually used in
the chart.

Extensive tests for the redis related part of this
chart are also added (including runtime checks on
the values).

Docs also updated.

Closes #11705
kaxil pushed a commit that referenced this pull request Jan 21, 2021
* Fix chart network policies definion and compliance

Followup to #12003:
* Some network policies & ingress are not valid
  against the jsonschema (empty values mostly)
* Some network policies conditionnal definitions
  were incorrect

* Support external redis instance in helm chart

The main objective here is to support the use
of an external redis instance in the helm chart.
The values 'data.brokerUrl' and
'data.brokerUrlSecretName' are added and
templates are updated.

This support is added with no breaking changes
(hopefully); only the redis.brokerURLSecretName
value is removed, but it wasn't actually used in
the chart.

Extensive tests for the redis related part of this
chart are also added (including runtime checks on
the values).

Docs also updated.

Closes #11705

(cherry picked from commit 809ddcd)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
* All k8s resources should have global labels

* All k8s object must comply with JSON Schema

(cherry picked from commit 3c85c2c)
cognifloyd pushed a commit to cognifloyd/stackstorm-k8s that referenced this pull request Feb 16, 2022
* All k8s resources should have global labels

* All k8s object must comply with JSON Schema

Partial Commit Extracted From: https://github.com/apache/airflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart okay to merge It's ok to merge this PR as it does not require more tests type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants