Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with empty Resources in executor_config #12633

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

dimberman
Copy link
Contributor

Fixes an issue where if a user specifies a request but not a limit in
resources for the executor_config, backwards compat can not parse

(cherry picked from commit 84eecf94bab1a8c66b5161f03c6631448fb4850e)


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@dimberman dimberman requested a review from kaxil November 25, 2020 22:45
@kaxil kaxil added the full tests needed We need to run full set of tests for this PR to merge label Nov 26, 2020
Fixes an issue where if a user specifies a request but not a limit in
resources for the executor_config, backwards compat can not parse

(cherry picked from commit 84eecf94bab1a8c66b5161f03c6631448fb4850e)
@kaxil kaxil merged this pull request into v1-10-test Nov 27, 2020
@kaxil kaxil deleted the fix-resource-backcompat branch November 27, 2020 13:52
@ashb
Copy link
Member

ashb commented Nov 27, 2020

@dimberman @kaxil PRs should be against v1-10-stable generally.

kaxil pushed a commit to astronomer/airflow that referenced this pull request Nov 27, 2020
Fixes an issue where if a user specifies a request but not a limit in
resources for the executor_config, backwards compat can not parse

(cherry picked from commit 84eecf94bab1a8c66b5161f03c6631448fb4850e)
(cherry picked from commit 74e02477bdd83880c2bc2b57ded36ef730dcacbb)
kaxil pushed a commit that referenced this pull request Nov 27, 2020
Fixes an issue where if a user specifies a request but not a limit in
resources for the executor_config, backwards compat can not parse

(cherry picked from commit 84eecf94bab1a8c66b5161f03c6631448fb4850e)
@potiuk potiuk added this to the Airflow 1.10.14 milestone Nov 30, 2020
@potiuk potiuk added the type:bug-fix Changelog: Bug Fixes label Nov 30, 2020
kaxil pushed a commit that referenced this pull request Dec 3, 2020
Fixes an issue where if a user specifies a request but not a limit in
resources for the executor_config, backwards compat can not parse

(cherry picked from commit 84eecf94bab1a8c66b5161f03c6631448fb4850e)
ashb pushed a commit that referenced this pull request Dec 3, 2020
Fixes an issue where if a user specifies a request but not a limit in
resources for the executor_config, backwards compat can not parse

(cherry picked from commit 84eecf94bab1a8c66b5161f03c6631448fb4850e)
kaxil pushed a commit to astronomer/airflow that referenced this pull request Dec 4, 2020
Fixes an issue where if a user specifies a request but not a limit in
resources for the executor_config, backwards compat can not parse

(cherry picked from commit 84eecf94bab1a8c66b5161f03c6631448fb4850e)
(cherry picked from commit 74e02477bdd83880c2bc2b57ded36ef730dcacbb)
(cherry picked from commit 7ef6354)
AntonyRileyAtVerto pushed a commit to vertoanalytics/incubator-airflow that referenced this pull request Feb 2, 2021
- BugFix: Tasks with ``depends_on_past`` or ``task_concurrency`` are stuck (apache#12663)
- Fix issue with empty Resources in executor_config (apache#12633)
- Fix: Deprecated config ``force_log_out_after`` was not used (apache#12661)
- Fix empty asctime field in JSON formatted logs (apache#10515)
- [AIRFLOW-2809] Fix security issue regarding Flask SECRET_KEY (apache#3651)
- [AIRFLOW-2884] Fix Flask SECRET_KEY security issue in www_rbac (apache#3729)
- [AIRFLOW-2886] Generate random Flask SECRET_KEY in default config (apache#3738)
- Add missing comma in setup.py (apache#12790)
- Bugfix: Unable to import Airflow plugins on Python 3.8 (apache#12859)
- Fix setup.py missing comma in ``setup_requires`` (apache#12880)
- Don't emit first_task_scheduling_delay metric for only-once dags (apache#12835)

- Update setup.py to get non-conflicting set of dependencies (apache#12636)
- Rename ``[scheduler] max_threads`` to ``[scheduler] parsing_processes`` (apache#12605)
- Add metric for scheduling delay between first run task & expected start time (apache#9544)
- Add new-style 2.0 command names for Airflow 1.10.x (apache#12725)
- Add Kubernetes cleanup-pods CLI command for Helm Chart (apache#11802)
- Don't let webserver run with dangerous config (apache#12747)
- Replace pkg_resources with importlib.metadata to avoid VersionConflict errors (apache#12694)

- Clarified information about supported Databases
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Fixes an issue where if a user specifies a request but not a limit in
resources for the executor_config, backwards compat can not parse

(cherry picked from commit 84eecf94bab1a8c66b5161f03c6631448fb4850e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants