Pass image_pull_policy in KubernetesPodOperator correctly #13289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
image_pull_policy is not being passed into the V1Container in KubernetesPodOperator.
boring-cyborg
bot
added
the
provider:cncf-kubernetes
KevYuen
changed the title
KevYuen
changed the title
KevYuen
force-pushed
the
image-pull-policy-k8s-pod
branch
from
2ccdb90
to
7cc5c63
Compare
potiuk
approved these changes
Dec 23, 2020
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
XD-DENG
requested changes
Dec 23, 2020
| @mock.patch("airflow.kubernetes.pod_launcher.PodLauncher.start_pod") | ||
| @mock.patch("airflow.kubernetes.pod_launcher.PodLauncher.monitor_pod") | ||
| @mock.patch("airflow.kubernetes.kube_client.get_kube_client") | ||
| def test_image_pull_policy_correctly_set(self, mock_client, monitor_mock, start_mock): |
There was a problem hiding this comment.
Shall we have one more test case, where we don't explicitly specify image_pull_policy then assert it against default value IfNotPresent ?
github-actions
bot
removed
the
okay to merge
image_pull_policy should be IfNotPresent by default if it's not set. The test ensure the correct value is passed to the V1Container object.
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
XD-DENG
changed the title
|
Thanks @XD-DENG! Much appreciated |
|
No problem ;-) Happy holidays ahead btw! |
potiuk
added a commit
to PolideaInternal/airflow
that referenced
this pull request
Dec 26, 2020
The apache#13289 fixed imagePullPolicy behaviour but broke master K8S tests. This PR attempts to fix it.
potiuk
added a commit
that referenced
this pull request
Dec 26, 2020
The #13289 fixed imagePullPolicy behaviour but broke master K8S tests. This PR attempts to fix it.
kaxil
pushed a commit
that referenced
this pull request
Jan 21, 2021
kaxil
pushed a commit
that referenced
this pull request
Jan 29, 2021
* pass image_pull_policy to V1Container image_pull_policy is not being passed into the V1Container in KubernetesPodOperator. This commit fixes this. * add test for image_pull_policy not set image_pull_policy should be IfNotPresent by default if it's not set. The test ensure the correct value is passed to the V1Container object. (cherry picked from commit 7a560ab)
kaxil
pushed a commit
that referenced
this pull request
Feb 4, 2021
* pass image_pull_policy to V1Container image_pull_policy is not being passed into the V1Container in KubernetesPodOperator. This commit fixes this. * add test for image_pull_policy not set image_pull_policy should be IfNotPresent by default if it's not set. The test ensure the correct value is passed to the V1Container object. (cherry picked from commit 7a560ab)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 23, 2021
The apache#13289 fixed imagePullPolicy behaviour but broke master K8S tests. This PR attempts to fix it. (cherry picked from commit 6f246b0) (cherry picked from commit fd0fddc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
image_pull_policy is not being passed into the V1Container in
KubernetesPodOperatorThis causes pods to not re-pull images even if the value is set.