Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imagePullPolicy missing in tests #13316

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 25, 2020

The #13289 fixed imagePullPolicy behaviour but broke master K8S
tests. This PR attempts to fix it.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 25, 2020
The apache#13289 fixed imagePullPolicy behaviour but broke master K8S
tests. This PR attempts to fix it.
@potiuk potiuk force-pushed the fix-image-pull-policy-missing-in-tests branch from cc9d669 to fe112d5 Compare December 26, 2020 00:09
@potiuk potiuk merged commit 6f246b0 into apache:master Dec 26, 2020
@potiuk potiuk deleted the fix-image-pull-policy-missing-in-tests branch December 26, 2020 00:44
@potiuk potiuk added this to the Airflow 2.0.1 milestone Jan 2, 2021
kaxil pushed a commit that referenced this pull request Jan 21, 2021
The #13289 fixed imagePullPolicy behaviour but broke master K8S
tests. This PR attempts to fix it.

(cherry picked from commit 6f246b0)
kaxil pushed a commit to astronomer/airflow that referenced this pull request Apr 23, 2021
The apache#13289 fixed imagePullPolicy behaviour but broke master K8S
tests. This PR attempts to fix it.

(cherry picked from commit 6f246b0)
(cherry picked from commit fd0fddc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants