Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #1 from airbnb/master #15

Closed
wants to merge 1 commit into from
Closed

Merge pull request #1 from airbnb/master #15

wants to merge 1 commit into from

Conversation

yffud
Copy link

@yffud yffud commented Jun 8, 2015

Update to master

@yffud yffud closed this Jun 8, 2015
zack3241 pushed a commit to zack3241/incubator-airflow that referenced this pull request Jan 25, 2018
    # This is a combination of 16 commits.
    # This is the 1st commit message:
    Add flask_admin_unescape function to airfow.www.utils

    # This is the commit message apache#2:

    Add flask_admin_unescape to TaskInstanceModelView for task_id and dag_id

    # This is the commit message apache#3:

    Add test_flask_admin_unescape to tests.www.test_utils

    # This is the commit message apache#4:

    Add TestTaskInstanceModelView to tests.www.test_views

        This test for the proper integration between Subdag Tasks and the
        flask_admin package. Because the flask_admin package uses '.'
        characters as it's escape character and airflow enforces the
        dag_id.subdag_id format for the dag_id's for task_id's in subdags,
        the escaping that flask_admin preforms causes a duplication of the
        '.' character. When perform the actions that are available for those
        task_instances via the ui, this causes an error. These tests are
        here to protect against that integration issue.

    # This is the commit message apache#5:

    Update airflow.www.utils to conform to flake8 standards

    # This is the commit message apache#6:

    Update tests.www.test_utils to conform to flake8 standards

    # This is the commit message apache#7:

    Update TestTaskInstanceModelView to Leverage assertEqual

    # This is the commit message apache#8:

    Remove Superfluous SubDAG Task Var TestTaskInstanceModelView

    # This is the commit message apache#9:

    Update airflow.www.utils.gizipped.view_func to match with flake8

    # This is the commit message apache#11:

    Update airflow.www._connection_ids to align with flake8 spacing

    # This is the commit message apache#12:

    Update tests.www.test_utils.test_flask_admin_unescape with proper spaces

    # This is the commit message apache#13:

    Align tests.www.test_views with flake8 standards

    # This is the commit message apache#14:

    Remove unnecessary SubDagOperator in tests.www.test_views

    # This is the commit message apache#15:

    Change Position on install_aliases call in www.utils for flake8

    # This is the commit message apache#16:

    Separate setting subdag state via flask_admin model tests
mobuchowski pushed a commit to mobuchowski/airflow that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant