Misc spelling updates #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -200,7 +200,7 @@ def clear(args): | |||
| dagbag = DagBag(args.subdir) | |||
|
|
|||
| if args.dag_id not in dagbag.dags: | |||
| raise Exception('dag_id could not be found') | |||
| raise Exception('dag_id could not be fouud') | |||
There was a problem hiding this comment.
This creates a spelling error, rather than correcting it
There was a problem hiding this comment.
😞 oops sorry, good catch
|
Woah. I didn't realize how much typos there was in there. I clearly need some sort of spell checker plugin in my vim. I'll merge as soon as you update the one thing @Mause pointed out. Thanks! |
|
None hurt my ability to use airflow, they seemed extremely minor to me. I noticed because my poor spelling caused frustration for an english as a second language colleague so I added these lines to my vimrc: hi clear SpellBad
hi SpellBad cterm=underline
set spell spelllang=en_usIt works pretty well for me with PyMode and not correcting |
|
Nice, I dropped those lines in my .vimrc and it seems to work well with my python config. Expect less typos from me in the future! Merging. |
zack3241
pushed a commit
to zack3241/incubator-airflow
that referenced
this pull request
Jan 25, 2018
# This is a combination of 16 commits.
# This is the 1st commit message:
Add flask_admin_unescape function to airfow.www.utils
# This is the commit message apache#2:
Add flask_admin_unescape to TaskInstanceModelView for task_id and dag_id
# This is the commit message apache#3:
Add test_flask_admin_unescape to tests.www.test_utils
# This is the commit message apache#4:
Add TestTaskInstanceModelView to tests.www.test_views
This test for the proper integration between Subdag Tasks and the
flask_admin package. Because the flask_admin package uses '.'
characters as it's escape character and airflow enforces the
dag_id.subdag_id format for the dag_id's for task_id's in subdags,
the escaping that flask_admin preforms causes a duplication of the
'.' character. When perform the actions that are available for those
task_instances via the ui, this causes an error. These tests are
here to protect against that integration issue.
# This is the commit message apache#5:
Update airflow.www.utils to conform to flake8 standards
# This is the commit message apache#6:
Update tests.www.test_utils to conform to flake8 standards
# This is the commit message apache#7:
Update TestTaskInstanceModelView to Leverage assertEqual
# This is the commit message apache#8:
Remove Superfluous SubDAG Task Var TestTaskInstanceModelView
# This is the commit message apache#9:
Update airflow.www.utils.gizipped.view_func to match with flake8
# This is the commit message apache#11:
Update airflow.www._connection_ids to align with flake8 spacing
# This is the commit message apache#12:
Update tests.www.test_utils.test_flask_admin_unescape with proper spaces
# This is the commit message apache#13:
Align tests.www.test_views with flake8 standards
# This is the commit message apache#14:
Remove unnecessary SubDagOperator in tests.www.test_views
# This is the commit message apache#15:
Change Position on install_aliases call in www.utils for flake8
# This is the commit message apache#16:
Separate setting subdag state via flask_admin model tests
justinsb
pushed a commit
to justinsb/incubator-airflow
that referenced
this pull request
Feb 6, 2018
…_pandas_gbq Added a workaround for a pandas_gbq issue when result table has 1 column
boralyl
pushed a commit
to upsight/airflow
that referenced
this pull request
Apr 1, 2019
…-2817 to develop * commit '768ee500963cab7b5e2172b871cfe0889da7a257': Bump version to 1.8.0-up1.2.0 DATA-2817: support celery worker --hostname arg
y2k-shubham
pushed a commit
to y2k-shubham/airflow
that referenced
this pull request
Apr 11, 2020
mobuchowski
pushed a commit
to mobuchowski/airflow
that referenced
this pull request
Jan 4, 2022
* Add circle_ci config * Add basic circleCI template * Add an integration-test target * Sample fix * Adding additional dependency in test-requirements * Add testing line * Add some install steps to install airflow for testing * Adjustments to install local airflow to run tests * Add additional necessary requirements * Add circle_ci fixes
mobuchowski
pushed a commit
to mobuchowski/airflow
that referenced
this pull request
Jan 4, 2022
add community link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading over the code to understand how everything works and ended up making minor spelling changes. None stopped functionality for me except a change in the iPython Notebook. I hope these changes might be useful.
This is an extremely helpful utility and a cool use of DAGs.