Fix kube client on mac with keepalive enabled #15551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`socket` on mac doesn't support `TCP_KEEPIDLE`, so when keepalive is enabled we should check before trying to set it so the defaults work on macs. We will be defensive with the other `TCP_KEEP*`s as well. https://github.com/websocket-client/websocket-client/blob/719fc9d2e50e16292b4f09ca86385540456a55a7/websocket/_socket.py#L37-L44
boring-cyborg
bot
added
the
provider:cncf-kubernetes
|
cc: @michalmisiewicz |
kaxil
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
socketon mac doesn't supportTCP_KEEPIDLE, so when keepalive isenabled we should check before trying to set it so the defaults work on
macs. We will be defensive with the other
TCP_KEEP*s as well.https://github.com/websocket-client/websocket-client/blob/719fc9d2e50e16292b4f09ca86385540456a55a7/websocket/_socket.py#L37-L44