Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kube client on mac with keepalive enabled #15551

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Fix kube client on mac with keepalive enabled #15551

merged 1 commit into from
Apr 27, 2021

Commits on Apr 27, 2021

  1. Fix kube client on mac with keepalive enabled 

    `socket` on mac doesn't support `TCP_KEEPIDLE`, so when keepalive is
enabled we should check before trying to set it so the defaults work on
macs. We will be defensive with the other `TCP_KEEP*`s as well.

https://github.com/websocket-client/websocket-client/blob/719fc9d2e50e16292b4f09ca86385540456a55a7/websocket/_socket.py#L37-L44
    @jedcunningham
    jedcunningham committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    b24476a View commit details
    Browse the repository at this point in the history