-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DiscordWebhookOperator - add webhook_endpoint to templated fields #22570
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
I rebased to check if the static code was just accidental main merge. |
The test failing is:
related to click releasing version 8.1.0 |
It should be fixed by #22599 |
Awesome work, congrats on your first merged pull request! |
Added webhook_endpoint to templated fields in DiscordWebhookOperator.
User might want to leverage templates for that field. In my case I wanted to use token saved in password field of a connection to avoid leaking the token to logs:
It's possible to overwrite templated fields later but this seems like a good default.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.