Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump black version for other pre-commit hooks #22599

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Mar 29, 2022

This PR/commit bumps the black version used in other pre-commit hooks as a follow up of #22598


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk
Copy link
Member

potiuk commented Mar 29, 2022

I must disappoint you @kaxil . I tried it before and welll ... more changes are needed ... You will see :).

@kaxil kaxil force-pushed the bump-black branch 2 times, most recently from 4d34eaf to 9674663 Compare March 29, 2022 20:33
@kaxil
Copy link
Member Author

kaxil commented Mar 29, 2022

I must disappoint you @kaxil . I tried it before and welll ... more changes are needed ... You will see :).

https://github.com/apache/airflow/runs/5744294853?check_suite_focus=true -- passed 🎉 😄

@potiuk
Copy link
Member

potiuk commented Mar 29, 2022

WAT ?

@potiuk
Copy link
Member

potiuk commented Mar 29, 2022

There is a problem with PROD build but I saw ?:#$%^QW? errors when I tried it ... I wonder what magic is in operations here :)

@eladkal
Copy link
Contributor

eladkal commented Mar 30, 2022

There is a problem with PROD build but I saw ?:#$%^QW? errors when I tried it ... I wonder what magic is in operations here :)

#64 13.65 The conflict is caused by:
#64 13.65     apache-airflow[amazon,async,celery,cncf-kubernetes,dask,docker,elasticsearch,ftp,google,google-auth,grpc,hashicorp,http,ldap,microsoft-azure,mysql,odbc,pandas,postgres,redis,sendgrid,sftp,slack,ssh,statsd,virtualenv] 2.3.0.dev0 depends on flask-appbuilder==3.4.5
#64 13.65     The user requested (constraint) flask-appbuilder==3.4.4
#64 13.65 
#64 13.65 To fix this you could try to:
#64 13.65 1. loosen the range of package versions you've specified
#64 13.65 2. remove package versions to allow pip attempt to solve the dependency conflict

probably just need a rebase after #22596 ?

@potiuk
Copy link
Member

potiuk commented Mar 30, 2022

It needed constraints bump :). Fixed it. This one needs rebase now :)

But I am still suspicious why it worked - when I tried it, it did not :)

@potiuk
Copy link
Member

potiuk commented Mar 30, 2022

BTW. The :#$%^QW? errors reffered to some Black errors (blacken docs) when I tried it before :)

This PR/commit bumps the black version used in other pre-commit hooks as a follow up of apache#22598
@kaxil
Copy link
Member Author

kaxil commented Mar 30, 2022

All passed :) @potiuk

@potiuk
Copy link
Member

potiuk commented Mar 30, 2022

I am surprised :) . But .... Well..

@potiuk potiuk merged commit 347e202 into apache:main Mar 30, 2022
@kaxil kaxil deleted the bump-black branch March 30, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants