Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hooks/exasol): handle non resultSet query result types #25227

Closed

Conversation

anja-istenic
Copy link
Contributor

@anja-istenic anja-istenic commented Jul 22, 2022

This PR fixes an issue introduced by b7c3c96 (authored by @kazanzhy) which added iterating over ExaStatement when using ExasolHook.run().
Iteration can only be done for statements with a result_type=resultSet, for other result types, pyexasol raises ExaRuntimeError(self.connection, 'Attempt to fetch from statement without result set'). This happens for all create and drop statements (their result type is rowCount).
Therefore, an extra check is needed before the iteration.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 22, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@kazanzhy
Copy link
Contributor

Thank you for your suggestions. I really missed it.

All hooks' logic is that we fetch results only when the handler is provided.
We're assuming that for not "SELECT" operations there is no need to use a handler.

So, here we could just add additional spaces in lines 174-176.
I already fixed it in #23971 and you just could use code from there
https://github.com/apache/airflow/pull/23971/files#diff-00b215634013629b320a263630bf6948ed33c2a8528754fc78d69484e1320845

@kazanzhy
Copy link
Contributor

UPD. #23971 is merged, therefore this issue probably is solved

@potiuk
Copy link
Member

potiuk commented Jul 22, 2022

Closing as solved by #23791. If you think @anja-istenic that it's not solved, please let us know.

@anja-istenic
Copy link
Contributor Author

Thanks both for your comments. I can confirm that PR #23971 fixes the issue I addressed with this PR. I would, however, suggest we still add the test I added here to ensure this doesn't break in the future. I've created a new PR for it: #25277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants