Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(hooks/exasol): add test for no resultSet rtn type #25277

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

anja-istenic
Copy link
Contributor

As my bugfix in this PR: #25227 has been fixed by another merge, I suggest we still add a test for this issue so as to not introduce a similar bug in the future.
The description of the bug this is testing:

Iteration over ExaStatement can only be done for statements with a result_type=resultSet.
For other result types, pyexasol raises ExaRuntimeError(self.connection, 'Attempt to fetch from statement without result set').
This happens for all create and drop statements (their result type is rowCount).

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@anja-istenic
Copy link
Contributor Author

@kazanzhy @potiuk Added an extra test for the exasol hook, as mentioned in #25227.

@potiuk
Copy link
Member

potiuk commented Jul 25, 2022

Cool!

@potiuk
Copy link
Member

potiuk commented Jul 25, 2022

I rebased it as we had some breaking main, so just in case.

@anja-istenic
Copy link
Contributor Author

Tests passed :) Are you able to merge this, @potiuk? I don't have permissions to do so

@anja-istenic
Copy link
Contributor Author

Hey @jedcunningham @bbovenzi @eladkal @potiuk, could one of you merge this PR?

@potiuk potiuk merged commit 4dc1778 into apache:main Jul 28, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 28, 2022

Awesome work, congrats on your first merged pull request!

@anja-istenic anja-istenic deleted the add-no-result-set-test branch July 28, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants