-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move provider issue generation to breeze #28352
Merged
potiuk
merged 1 commit into
apache:main
from
potiuk:move-generate-issue-content-for-providers-to-breeze
Dec 14, 2022
Merged
Move provider issue generation to breeze #28352
potiuk
merged 1 commit into
apache:main
from
potiuk:move-generate-issue-content-for-providers-to-breeze
Dec 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
kaxil,
ashb,
mik-laj and
jedcunningham
as code owners
December 14, 2022 02:16
potiuk
force-pushed
the
move-generate-issue-content-for-providers-to-breeze
branch
from
December 14, 2022 02:17
f51580b
to
7ed1f77
Compare
The exercise where another PMC performed a release process had proven useful to show the value of Breeze in release management commands - there were no problems with running the Breeze commands, but for scripts put elsewhere (docs building, dev) it was a bit problematic because each required own virtualenv. This is the first PR to simplify that - one less venv for the issue generation process - now it is moved to Breeze so no more setup is needed.
potiuk
force-pushed
the
move-generate-issue-content-for-providers-to-breeze
branch
from
December 14, 2022 02:24
7ed1f77
to
949dea3
Compare
eladkal
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
That will save time for next release
potiuk
deleted the
move-generate-issue-content-for-providers-to-breeze
branch
December 14, 2022 08:20
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 2, 2023
The apache#28352 introduced subtle bugs which failed when runnint it during provider generation. Also added running the command automatically in CI.
pierrejeambrun
added
the
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
label
Mar 6, 2023
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 6, 2023
The exercise where another PMC performed a release process had proven useful to show the value of Breeze in release management commands - there were no problems with running the Breeze commands, but for scripts put elsewhere (docs building, dev) it was a bit problematic because each required own virtualenv. This is the first PR to simplify that - one less venv for the issue generation process - now it is moved to Breeze so no more setup is needed. (cherry picked from commit fd5846d)
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exercise where another PMC performed a release process had proven useful to show the value of Breeze in release management commands - there were no problems with running the Breeze commands, but for scripts put elsewhere (docs building, dev) it was a bit problematic because each required own virtualenv.
This is the first PR to simplify that - one less venv for the issue generation process - now it is moved to Breeze so no more setup is needed.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.