Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move provider issue generation to breeze #28352

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 14, 2022

The exercise where another PMC performed a release process had proven useful to show the value of Breeze in release management commands - there were no problems with running the Breeze commands, but for scripts put elsewhere (docs building, dev) it was a bit problematic because each required own virtualenv.

This is the first PR to simplify that - one less venv for the issue generation process - now it is moved to Breeze so no more setup is needed.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk requested a review from eladkal December 14, 2022 02:16
@potiuk potiuk force-pushed the move-generate-issue-content-for-providers-to-breeze branch from f51580b to 7ed1f77 Compare December 14, 2022 02:17
The exercise where another PMC performed a release process had
proven useful to show the value of Breeze in release management
commands - there were no problems with running the Breeze commands,
but for scripts put elsewhere (docs building, dev) it was a bit
problematic because each required own virtualenv.

This is the first PR to simplify that - one less venv for the
issue generation process - now it is moved to Breeze so no more
setup is needed.
@potiuk potiuk force-pushed the move-generate-issue-content-for-providers-to-breeze branch from 7ed1f77 to 949dea3 Compare December 14, 2022 02:24
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!
That will save time for next release

@potiuk potiuk merged commit fd5846d into apache:main Dec 14, 2022
@potiuk potiuk deleted the move-generate-issue-content-for-providers-to-breeze branch December 14, 2022 08:20
potiuk added a commit to potiuk/airflow that referenced this pull request Jan 2, 2023
The apache#28352 introduced subtle bugs which failed when runnint it during
provider generation.

Also added running the command automatically in CI.
potiuk added a commit that referenced this pull request Jan 2, 2023
#28683)

The #28352 introduced subtle bugs which failed when runnint it during
provider generation.

Also added running the command automatically in CI.
@pierrejeambrun pierrejeambrun added this to the Airflow 2.5.2 milestone Mar 6, 2023
@pierrejeambrun pierrejeambrun added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 6, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 6, 2023
The exercise where another PMC performed a release process had
proven useful to show the value of Breeze in release management
commands - there were no problems with running the Breeze commands,
but for scripts put elsewhere (docs building, dev) it was a bit
problematic because each required own virtualenv.

This is the first PR to simplify that - one less venv for the
issue generation process - now it is moved to Breeze so no more
setup is needed.

(cherry picked from commit fd5846d)
ephraimbuddy pushed a commit that referenced this pull request Mar 8, 2023
#28683)

The #28352 introduced subtle bugs which failed when runnint it during
provider generation.

Also added running the command automatically in CI.

(cherry picked from commit 69ab7d8)
ephraimbuddy pushed a commit that referenced this pull request Mar 9, 2023
#28683)

The #28352 introduced subtle bugs which failed when runnint it during
provider generation.

Also added running the command automatically in CI.

(cherry picked from commit 69ab7d8)
ephraimbuddy pushed a commit that referenced this pull request Mar 10, 2023
#28683)

The #28352 introduced subtle bugs which failed when runnint it during
provider generation.

Also added running the command automatically in CI.

(cherry picked from commit 69ab7d8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants